xbee: make address length configurable #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: enhancement
| @@ -104,6 +117,7 @@ typedef struct { | |||
| gpio_t sleep_pin; /**< GPIO pin connected to SLEEP */ | |||
| ng_nettype_t proto; /**< protocol the interface speaks */ | |||
| uint8_t options; /**< options field */ | |||
| uint8_t addr_flags; /**< address flags as defined above */ | |||
There was a problem hiding this comment.
why do you introduce a new flag? Just use one bit of the options flag (thats what it is for...).
There was a problem hiding this comment.
I wasn't sure if these were not device dependent, since they are added to the tx-buffer in https://github.com/authmillenon/RIOT/blob/xbee/enh/addr-len/drivers/xbee/xbee.c#L553
There was a problem hiding this comment.
you are right, forget what I said..
|
If you test this and say its working I will give my ACK. |
|
Works: |
6LoWPAN-ND states [1] that the IPv6 address should be generated from the EUI-64 of the interface, since it can be assumed as globally unique and would not require duplicate address detection. Currently the xbee module is not able to use any other address for short address with IPv6 since NETCONF_OPT_SRC_LEN always returns 2. This patch fixes that. [1] https://tools.ietf.org/html/rfc6775#section-5.2
miri64
force-pushed
the
xbee/enh/addr-len
branch
from
069247c to
f4392f7
Compare
|
Accidentally amended fix ( |
miri64
added
the
CI: ready for build
|
ACK when Travis is happy. |
|
and go. |
haukepetersen
added a commit
that referenced
this pull request
Jun 12, 2015
xbee: make address length configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6LoWPAN-ND states [1] that the IPv6 address should be generated from the EUI-64 of the interface, since it can be assumed as globally unique and would not require duplicate address detection. Currently the xbee module is not able to use any other address for short address with IPv6 since
NETCONF_OPT_SRC_LEN always returns 2. This patch fixes that.
[1] https://tools.ietf.org/html/rfc6775#section-5.2