gnrc: Fix #3597 (multi-hop ping) #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: bug
Closed
miri64
added
the
CI: needs squashing
|
I would still strongly argue for splitting next-hop and neighbor cache lookup into separate functions. Even more splitting of this function would be beneficial. |
| @@ -689,6 +689,7 @@ static void _receive(ng_pktsnip_t *pkt) | |||
| ipv6->next = pkt; /* reorder for sending */ | |||
| pkt->next = NULL; | |||
| _send(ipv6, false); | |||
| return; | |||
There was a problem hiding this comment.
Ah, that was probably the cause for the segfaults I saw yesterday.
|
The fix itself looks good. Will test now |
|
Confirmed working. ACK |
miri64
added
CI: ready for build
miri64
force-pushed
the
gnrc_ndp/fix/i3597
branch
from
47ef3ff to
9f3cef5
Compare
|
Squashed. |
|
|
OlegHahm
added a commit
that referenced
this pull request
Aug 14, 2015
gnrc: Fix #3597 (multi-hop ping)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3597
Less invasive alternative to #3622.