Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netdev2_tap: set maximum buffer size correctly #3826

Merged
merged 1 commit into from
Sep 15, 2015
Merged

netdev2_tap: set maximum buffer size correctly #3826

merged 1 commit into from
Sep 15, 2015

Conversation

OlegHahm
Copy link
Member

@kaspar030, I didn't get the rationale for 576 in the first place, but this results in broken pinging with a payload bigger than 514 bytes.

@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Sep 11, 2015
@OlegHahm OlegHahm added this to the Release 2015.09 milestone Sep 11, 2015
@cgundogan
Copy link
Member

I was curious about the 576:

The Internet Protocol requires that hosts must be able to process IP datagrams of at least 576 bytes (for IPv4) or 1280 bytes (for IPv6). [1]

[1] https://en.wikipedia.org/wiki/Maximum_transmission_unit

@OlegHahm OlegHahm mentioned this pull request Sep 11, 2015
Closed
@kaspar030
Copy link
Contributor

ACK. Sorry, that was a leftover from testing on the RAM-constrained nucleo-f334.

@kaspar030
Copy link
Contributor

Actually, no. That function must return ETHERNET_FRAME_LEN.

@OlegHahm OlegHahm force-pushed the netdev2_tap_buffer_size branch from 5937d15 to fd121a9 Compare September 12, 2015 10:06
@OlegHahm
Copy link
Member Author

Updated and squashed immediately.

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 12, 2015
@cgundogan
Copy link
Member

ACK. kicked travis

@kaspar030
Copy link
Contributor

& go

kaspar030 added a commit that referenced this pull request Sep 15, 2015
@kaspar030
Merge pull request #3826 from OlegHahm/netdev2_tap_buffer_size
dd87073 
netdev2_tap: set maximum buffer size correctly
@kaspar030 kaspar030 merged commit dd87073 into RIOT-OS:master Sep 15, 2015
@OlegHahm OlegHahm deleted the netdev2_tap_buffer_size branch September 15, 2015 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kaspar030 kaspar030

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2015.09
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegHahm @cgundogan @kaspar030