Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: add -t <port> option to native again #3908

Closed
wants to merge 4 commits into from

Conversation

cgundogan
Copy link
Member

This PR brings back the option to set a port and daemonize native in order to use it with desvirt or netcat.
Can be tested with ./bin/native/gnrc_networking -t 12107 and then nc localhost 12107.

@emmanuelsearch @thomaseichinger can anyone of you test this on OS X?

@cgundogan cgundogan added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: native Platform: This PR/issue effects the native platform labels Sep 20, 2015
@cgundogan cgundogan added this to the Release NEXT MAJOR milestone Sep 20, 2015
@kaspar030
Copy link
Contributor

This shouldn't be part of riot.

@OlegHahm
Copy link
Member

This shouldn't be part of riot.

What and why not?

@kaspar030
Copy link
Contributor

Sorry, let me rephrase. IMHO this should not be in the RIOT native port, but be provided by a small external tool.

@miri64
Copy link
Member

miri64 commented Sep 20, 2015

So instead of putting stdio through something else than stdio (sockets in this case) we should parse stdio and provide (e.g.) UART-like behavior through an external tool?!?

@kaspar030
Copy link
Contributor

No. RIOT native already has in-RIOT stdio <-> linux stdio. Adding support to pipe all that through a socket can of course be done within RIOT, but it adds a lot of unnecessary complexity. I'd rather see a small tool that does the job from the outside.

Maybe we can even reuse something existing, e.g., socat EXEC:bin/native/default.elf,end-close,stderr,pty TCP-L:8888,reuseaddr,fork.

@cgundogan
Copy link
Member Author

+1 for the socat idea. Maybe it's really the better route to go with external tools here?

@OlegHahm
Copy link
Member

👍

@cgundogan
Copy link
Member Author

I just tested quickly with socat and one thing I noticed is that the pipe breaks when I attach/detach several times from that running instance. We need to cleverly bypass this somehow

@kaspar030
Copy link
Contributor

@cgundogan How do you test that?

@cgundogan
Copy link
Member Author

@kaspar030 can you have a look at des-testbed/desvirt#17 ? Is this what you had in mind?

@LudwigKnuepfer
Copy link
Member

I have no particular opinion on the topic.

@kaspar030
Copy link
Contributor

I'll close this in favour of des-testbed/desvirt#17.

@kaspar030 kaspar030 closed this Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: native Platform: This PR/issue effects the native platform Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants