Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: add example of border router with XBee on native platform. #4448

Closed
wants to merge 4 commits into from
Closed

examples: add example of border router with XBee on native platform. #4448

wants to merge 4 commits into from

Conversation

Yonezawa-T2
Copy link
Contributor

I'm struggling to make my Mac with XBee connected by USB to be a border router of 6LoWPAN. My objective is not fully achieved, but this example is useful to test modification of #4443, #4444, #4445, #4446, and #4447. This example depends on those PRs. The branch https://github.com/Yonezawa-T2/RIOT/tree/xbee_border_router is the master branch merged with those pull requests.

This PR may or may not be broken by #3622. I will investigate later.

@OlegHahm OlegHahm added Area: network Area: Networking Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: waiting for other PR State: The PR requires another PR to be merged first NSTF labels Dec 9, 2015
@miri64
Copy link
Member

miri64 commented Dec 9, 2015

I'm sorry I neither knew up until now, that native has a UART interface, nor that much about Xbee. I reassign.

@miri64 miri64 assigned haukepetersen and unassigned miri64 Dec 9, 2015
miri64
miri64 reviewed Dec 9, 2015
View reviewed changes
examples/gnrc_xbee_border_router/README.md
in the Makefile. If the baudrate is other than 9600, configure it in
`xbee_conf.h`.

See `img/page_001.svg` for the organization of modules and devices.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can link images with the ![Caption](link) syntax. With this notation, people who look at this page in the parsed version wouldn't likely know what you mean ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we cannot preview it on GitHub. Converting image to PNG may help.

This was referenced Dec 16, 2015
Closed
Merged
@kYc0o
Copy link
Contributor

kYc0o commented Jan 25, 2016

Any news on this PR?

@Yonezawa-T2 Yonezawa-T2 mentioned this pull request Feb 4, 2016
Merged
@OlegHahm OlegHahm added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Feb 27, 2016
@miri64 miri64 modified the milestone: Release 2016.07 Mar 29, 2016
@Yonezawa-T2 Yonezawa-T2 force-pushed the gnrc_xbee_border_router_example branch from 46b4fc8 to 3bcced9 Compare March 30, 2016 05:25
@kYc0o
Copy link
Contributor

kYc0o commented Apr 19, 2016

AFAIK, all the dependencies on this PR have been merged. Can you rebase and re-test if everything is ok? Thanks for all your contributions!

@kYc0o kYc0o removed Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties State: waiting for other PR State: The PR requires another PR to be merged first labels Apr 19, 2016
kYc0o
kYc0o reviewed Apr 19, 2016
View reviewed changes
examples/gnrc_xbee_border_router/xbee_params.h
static xbee_params_t xbee_params[] = {
{ .uart = XBEE_UART,
.baudrate = 9600U,
// .baudrate = 115200U,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use C style comments? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even remove the line since it doesn't hurt...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@Yonezawa-T2 Yonezawa-T2 force-pushed the gnrc_xbee_border_router_example branch from 3bcced9 to 9a1b993 Compare April 20, 2016 08:43
@Yonezawa-T2
Copy link
Contributor Author

Rebased. You may need #5364 for Clang.

@miri64
Copy link
Member

miri64 commented Apr 20, 2016

Was already fixed in #5360.

@kYc0o
Copy link
Contributor

kYc0o commented May 30, 2016

@Yonezawa-T2 sorry for the loooong delay, but I think we're ready to merge this. Can you please rebase to update your PR?

@Yonezawa-T2 Yonezawa-T2 force-pushed the gnrc_xbee_border_router_example branch from c27c01c to 7748e3b Compare May 31, 2016 01:23
@Yonezawa-T2
Copy link
Contributor Author

Rebased and squashed. I'm worrying about the scenario 1 in README.md. It may no longer work because RIOT respects RFC strictly now. I don't have enough time to test it.

@kYc0o
Copy link
Contributor

kYc0o commented Jul 25, 2016

All the dependencies of this PR are merged now. Can you make the needed tests and try to merge it for the next release? It seems a very interesting PR.

@kYc0o
Copy link
Contributor

kYc0o commented Jan 9, 2017

I was aiming to merge this since longtime ago, IMHO it's a wonderful PR which can help to configure a BR very quickly on OS X, since for now we don't have a easy-to-setup BR solution on this OS.
@Yonezawa-T2 can you rebase to master? and maybe rebase to #6235 (or we can just wait to get it merged).

I successfully configured OS X with the XBee with this PR.

@Yonezawa-T2 Yonezawa-T2 force-pushed the gnrc_xbee_border_router_example branch from 520f40f to 69c20f8 Compare January 11, 2017 03:02
@Yonezawa-T2
Copy link
Contributor Author

@kYc0o, I have rebased and updated it to work with #6235. Not tested with actual XBee devices (I cannot access to them for now).

@kYc0o
Copy link
Contributor

kYc0o commented Jan 11, 2017

Well now it hangs while setting a new address... before the rebase and the last commit it worked correctly...

@Yonezawa-T2
Copy link
Contributor Author

  • EXC_BAD_ACCESS because vector[0].iov_len in xbee_send is 4294967212 (i.e. (size_t)(-84))
  • because xbee_build_hdr called from xbee_adpt_send returns -EOVERFLOW (-84)
  • because payload_len is 104 while XBEE_MAX_PAYLOAD_LENGTH is 100 (or 95 with encryption)

Note xbee_get returns XBEE_MAX_PAYLOAD_LENGTH for NETOPT_MAX_PACKET_SIZE correctly.

I don't have enough time to dig deeper. Sorry.

@kYc0o
Copy link
Contributor

kYc0o commented Jan 24, 2017

Won't make it for this release unfortunately...

@kYc0o kYc0o modified the milestones: Release 2017.04, Release 2017.01 Jan 24, 2017
@aabadie aabadie mentioned this pull request Jun 12, 2017
Closed
@aabadie
Copy link
Contributor

aabadie commented Jun 12, 2017

What's the status here @Yonezawa-T2 ?

@kYc0o
Copy link
Contributor

kYc0o commented Nov 7, 2017

Ping @Yonezawa-T2 !

@smlng
Copy link
Member

smlng commented Dec 15, 2017

IMHO we already have a good deal of gnrc_* examples in our main repo. How about moving this PR to the applications repository? And close here as memo?

@kYc0o
Copy link
Contributor

kYc0o commented Dec 25, 2017

I'm super interested on re-working this PR. @smlng you might close it as memo if you want. Regarding the examples issue, I'd say we can re-discuss it again when I have the time to re-open this.

@Yonezawa-T2 is not responsive anymore, but anyways thanks for the already (hard) work done!

@smlng
Copy link
Member

smlng commented Jan 12, 2018

closing as memo as suggested, removing milestone as well

@smlng smlng closed this Jan 12, 2018
@smlng smlng added the State: archived State: The PR has been archived for possible future re-adaptation label Jan 12, 2018
@smlng smlng removed this from the Release 2018.01 milestone Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emmanuelsearch emmanuelsearch

@kYc0o kYc0o

Labels
Area: network Area: Networking CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: archived State: The PR has been archived for possible future re-adaptation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Yonezawa-T2 @miri64 @kYc0o @aabadie @smlng @haukepetersen @OlegHahm @emmanuelsearch @kaspar030