shell fib: recognize the default route as net prefix #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BytesGalore
added
Type: bug
cgundogan
added
the
Process: needs backport
cgundogan
added
the
CI: ready for build
|
ACK and go whe ntravis is green. Please provide a backport to the release branch |
34 tasks
|
Fixes the problems I had in the release specs, so I second that ACK. |
miri64
added a commit
that referenced
this pull request
Jan 6, 2016
shell fib: recognize the default route as net prefix
cgundogan
removed
the
Process: needs backport
cgundogan
added a commit
that referenced
this pull request
Jan 7, 2016
…ckport shell fib: recognize the default route as net prefix (backport of #4584)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
The
fibroutecommand always handles given destination as host prefixes, resulting in not setting the right flag.This "quickfix" enables
fibroutecommand to recognize at least the default route, i.e. all0address.With #4279 this will change entirely, then allowing to give a precise prefix length with the
fibroutecommand.