Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: fix board common module names #4970

Merged
merged 3 commits into from
Mar 8, 2016

Conversation

kaspar030
Copy link
Contributor

"Our build system calls "make -C" for every DIRS entry, which contain the modules.
Now, that make call compiles all sources into .o's and then takes all .o's of the module's bindir directory and archives them into module.a.

Now if multiple DIRS define the same module, as long as the "make -C" calls are called sequentially, the second make would just pick up the modules from the first.

If they're called in parallel, the archives might miss some objects.

So unless we fix this, no two DIRS can compile into the same .a."
#4964 but for qemu-i386, msb-430 and wsn-430.

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: build system Area: Build system labels Mar 6, 2016
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2016
@jnohlgard jnohlgard assigned jnohlgard and unassigned LudwigKnuepfer Mar 8, 2016
@jnohlgard
Copy link
Member

#4797 did the same change but for the periph subdirectories

@jnohlgard
Copy link
Member

ACK & go

jnohlgard pushed a commit that referenced this pull request Mar 8, 2016
@jnohlgard jnohlgard merged commit 49a7368 into RIOT-OS:master Mar 8, 2016
@kaspar030 kaspar030 deleted the fix_board_common_module_names branch February 7, 2017 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants