tests: combine similar network driver tests #5286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspar030
added
Area: network
|
Let's postpone this for the next release. |
kaspar030
force-pushed
the
reduce_tests
branch
from
93b77c3 to
479650e
Compare
kaspar030
force-pushed
the
reduce_tests
branch
from
479650e to
74d783e
Compare
kaspar030
added
the
CI: ready for build
|
Postponed due to feature freeze |
|
This got postponed for already two releases without a real cause as far as I can see - all the more reason to get it merged for this release. |
miri64
reviewed
Jan 17, 2017
| include Makefile.xbee | ||
|
|
||
| # test if multiple drivers are compiled in | ||
| ifneq (x,$(DRIVERS)) |
There was a problem hiding this comment.
This always seem to be the case, when I parse the included makefiles correctly. Please explain.
|
Could also benefit of some README and/or test script. |
|
No time to work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All those tests basically link in the driver and most parts of gnrc.
This PR combines them into one test in order to reduce the amount of redundant compilation.