-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/bmp180: implementation cleanup #5679
Conversation
@PeterKietzmann, I applied the timing change requested by @keestux in #5589. Tested here, it works. |
Thx. If @keestux confirms until tomorrow I will merge this PR as bugfix. |
I'm a bit overloaded. I'll try to look at it asap |
Yes, I confirm that it works. |
I got the order to ask our release manager @kYc0o whether it is ok to merge this PR as a bugfix or if the clean-up is too much during feature freeze. Sorry for not acting as I promised :/ |
@PeterKietzmann Yes, go ahead and close #5589 |
If you say it's a bug-fix I would add it to the current release. |
Of course if it's a bug-fix it should be in. Can anyone ACK this? |
ACK and go |
This PR makes a little bit of cleanup in the bmp180 sensor driver implementation.
Following #5589, I also made some tests and noticed that this line was not needed. As I only tried with a samr21-xpro board, it needs confirmation by someone else.