-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys: remove config module #5756
Conversation
👍 for removing this, but we definitely need a replacement. |
I suggest a vfs or nvram based replacement. that should go in a separate PR Den 18 aug. 2016 10:46 AM skrev "Oleg Hahm" notifications@github.com:
|
Sounds a bit like overkill to me. Think of MSP430 and its INFOMEM (a small flash section, intended to store persistent device specific information). |
So should we close this #162 issue? |
Why would it be overkill to implement a very simple read-only vfs backend for this and make it something comparible to |
A whole filesystem to store some bytes in a persistent way sounds certainly like overkill to me and I don't see any benefit. |
@OlegHahm I didn't mean a whole file system for a config store. What I meant is that the implementation should be either an NVRAM device, or a file-like persistent memory using the VFS API. Using familiar APIs such as vfs_read/write would just make it easier to use from an application developer point of view. |
I guess it is worthwhile to move the discussion about what to do as a replacement to a dedicated issue. |
I agree, I think since this PR has been open for more than a week, I don't think anyone will mind that we remove this module until a replacement is ready. |
17aa63c
to
b3a061e
Compare
|
ACK |
IMHO this module is unmaintained and unused... Do we still need it?