Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/sodaq-autonomo: use comma on last element of a list too #5922

Merged
merged 1 commit into from
Oct 11, 2016
Merged

boards/sodaq-autonomo: use comma on last element of a list too #5922

merged 1 commit into from
Oct 11, 2016

Conversation

keestux
Copy link
Contributor

@keestux keestux commented Oct 10, 2016 •
edited by jnohlgard
Loading

Since this is about the code that I contributed, and I feel responsible for it. I want to have the commas
added to the last entries of the lists.

This isn't in the Coding Conventions, but this is how I want it to be.
I have my pride too :-)

@jnohlgard jnohlgard added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 11, 2016
@jnohlgard
Copy link
Member

ACK, merge when Murdock agrees

@PeterKietzmann PeterKietzmann merged commit 39eb559 into RIOT-OS:master Oct 11, 2016
@miri64 miri64 added this to the Release 2016.10 milestone Oct 17, 2016
@miri64
Copy link
Member

miri64 commented Oct 18, 2016

Mhhhh... doesn't this contradict #5561?

@keestux keestux deleted the fix_sam0_padcfg_add_commas branch January 3, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2016.10
Development

Successfully merging this pull request may close these issues.
4 participants
@keestux @jnohlgard @miri64 @PeterKietzmann