ieee802154: centralize default values #5977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
force-pushed
the
ieee802154/enh/centralize-default-values
branch
from
f686ab1 to
6d8d6fc
Compare
smlng
reviewed
Oct 21, 2016
| @@ -45,7 +45,7 @@ extern "C" { | |||
| /** | |||
| * @brief Maximum possible packet size in byte | |||
| */ | |||
| #define AT86RF2XX_MAX_PKT_LENGTH (127) | |||
| #define AT86RF2XX_MAX_PKT_LENGTH (IEEE802154_MAX_FRAME_LEN) | |||
There was a problem hiding this comment.
mhm, the naming seems somewhat inconsistent here it is IEEE802154_MAX_FRAME_LEN instead of IEEE802154_FRAME_LEN_MAX compare to above IEEE802154_CHANNEL_MAX. Or what's the rational?
| #endif | ||
| #define AT86RF2XX_MIN_CHANNEL (IEEE802154_CHANNEL_MIN) | ||
| #define AT86RF2XX_MAX_CHANNEL (IEEE802154_CHANNEL_MAX) | ||
| #define AT86RF2XX_DEFAULT_CHANNEL (IEEE802154_DEFAULT_CHANNEL) |
There was a problem hiding this comment.
same here why its not IEEE802154_CHANNEL_DEFAULT?
There was a problem hiding this comment.
look at how they are grouped in net/ieee802154.h and this naming makes more sense ;-)
There was a problem hiding this comment.
I see these macros as legacy wrapper so if the definitions of those look a little bit weird I'm not that sad as a clean definition of the new macros ;-)
|
|
||
| /** | ||
| * @brief Default TX power (0dBm) | ||
| */ | ||
| #define AT86RF2XX_DEFAULT_TXPOWER (0U) | ||
| #define AT86RF2XX_DEFAULT_TXPOWER (IEEE802154_DEFAULT_TXPOWER) |
smlng
approved these changes
Oct 22, 2016
smlng
added
the
CI: ready for build
miri64
force-pushed
the
ieee802154/enh/centralize-default-values
branch
from
88d0016 to
4e789ed
Compare
|
Squashed |
smlng
added
CI: ready for build
The config assumed it was a 2.4 GHz radio. This solution isn't perfect either but eliminates a few more cases.
miri64
force-pushed
the
ieee802154/enh/centralize-default-values
branch
from
4e789ed to
964cd75
Compare
|
Rebased to current master. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3291.
I also changed up the selection of the default channel a little bit, since it was limited to 2.4 GHz IEEE 802.15.4 only. This solution isn't perfect either, but better than the previous one I think.