Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/kw2xrf: adapt to netdev2 #6453

Merged
merged 6 commits into from
Feb 7, 2017
Merged

drivers/kw2xrf: adapt to netdev2 #6453

merged 6 commits into from
Feb 7, 2017

Conversation

smlng
Copy link
Member

@smlng smlng commented Jan 23, 2017

tries to fix remaining issues in #5469

@smlng smlng added Area: drivers Area: Device drivers Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Jan 23, 2017
@smlng smlng force-pushed the pr/5469-bis branch 2 times, most recently from 08e9f40 to 5ada426 Compare January 23, 2017 10:52
@smlng smlng mentioned this pull request Jan 23, 2017
Merged
@smlng
Copy link
Member Author

smlng commented Jan 23, 2017 •
edited
Loading

requires #6454

@smlng smlng added the State: waiting for other PR State: The PR requires another PR to be merged first label Jan 23, 2017
@jfischer-no
Copy link
Contributor

@smlng Thanks, would you like to rebase it, or should I take it to #5469?

@smlng
Copy link
Member Author

smlng commented Jan 23, 2017

@jfischer-phytec-iot its based on your PR, so we could close yours and merge this one instead, if you're okay with this procedure?! Your commits would stay as they are, so no work and effort lost.

@smlng
Copy link
Member Author

smlng commented Jan 23, 2017

@jfischer-phytec-iot , we still have to wait for the SPI rework PR #4780, and this has to be adapted to it before final merge. @PeterKietzmann will help with that

@jfischer-no
Copy link
Contributor

@jfischer-phytec-iot its based on your PR, so we could close yours and merge this one instead, if >you're okay with this procedure?! Your commits would stay as they are, so no work and effort lost.

I agree, thank you

@smlng smlng mentioned this pull request Jan 23, 2017
Closed
@PeterKietzmann PeterKietzmann mentioned this pull request Jan 24, 2017
Closed
@PeterKietzmann
Copy link
Member

@smlng can you check if this PR fixes #4822 as you stated there? Anyway, it should not block this PR from being merged as long as the issue persists. However, we're still waiting for the SPI rework to be merged before.

@PeterKietzmann
Copy link
Member

BTW I've tested some stress pinging with small payloads (un-fragmented 6Lo) between a samr21 and a phytec board with success.

@smlng
Copy link
Member Author

smlng commented Jan 24, 2017

@PeterKietzmann could to know that basic test succeeded. Regarding #4822: I'll try to do extend tests soon, but I won't make it for the release. Still, as suggested that should not block this PR in general.

@OlegHahm
Copy link
Member

@smlng, care to update the PR title to something more speaking? ;-)

@PeterKietzmann PeterKietzmann changed the title PR 5469-bis drivers/kw2xrf: adapt to netdev2 Jan 25, 2017
@PeterKietzmann
Copy link
Member

#4780 has been merged. Please rebase!

@smlng
Copy link
Member Author

smlng commented Jan 25, 2017

@PeterKietzmann its not that simple, but I'll try

@smlng smlng removed State: waiting for other PR State: The PR requires another PR to be merged first State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Jan 27, 2017
@smlng
Copy link
Member Author

smlng commented Jan 27, 2017

adapted to new SPI interface and rebased, needs testing

@smlng smlng requested a review from PeterKietzmann February 2, 2017 15:51
@smlng
Copy link
Member Author

smlng commented Feb 3, 2017

@PeterKietzmann ping, 🍒

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Feb 6, 2017
@PeterKietzmann
Copy link
Member

Fragmentation does not work as reported in #4822 I guess. Small packet hardcore pinging on different channels works between samr21-xpro and the phytec board. Let me have a look at the code again

@PeterKietzmann
Copy link
Member

Please review #1

@PeterKietzmann
Copy link
Member

I don't think we need all commits. Please squash. IMO one commit should be fine. Maybe two. For example one commit containing the netdev2 adoption and the other containing SPI rework. I trust you to find a reasonable decision to squash your commits.

@smlng smlng force-pushed the pr/5469-bis branch 2 times, most recently from 47f3b24 to d1842d2 Compare February 7, 2017 14:06
jfischer-no and others added 5 commits February 7, 2017 15:07
@jfischer-no @smlng
drivers/kw2xrf: adapt for the netdev2 interface
cf32ff7 
Adapt the kw2xrf driver for the netdev2 interface.
This patch also adds overwrites.h, the header provides overwrite
values for the kw2xrf PHY.
@jfischer-no @smlng
tests/driver_kw2xrf: adapt for netdev2 and add testmodes
5eccbfb
@smlng
drivers/kw2xrf: adapt to new SPI interface
887f499 
    - add docu for structs, defines and functions
    - exclude drivers/kw2xrf/include/overwrites.h (vendor header)
    - add missing header guards
@smlng
drivers/kw2xrf: cleanup
432b03e 
    - use generic short and long address generator
    - defines in main header file
    - refine debug output
    - correct signed/unsigned warnings
@PeterKietzmann @smlng
drivers/kw2xrf: update default params on init
e617d74
@smlng
Copy link
Member Author

smlng commented Feb 7, 2017

squashed as much as I found reasonable, and so that everyone involved gets his share 😄

PeterKietzmann
PeterKietzmann approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I'm a bit scared I give my tested ACK.

@PeterKietzmann PeterKietzmann merged commit 5bf4882 into RIOT-OS:master Feb 7, 2017
@PeterKietzmann
Copy link
Member

Thanks @jfischer-phytec-iot for your initial work and @smlng for shepherding.

@smlng
Copy link
Member Author

smlng commented Feb 7, 2017

finally!

@smlng smlng deleted the pr/5469-bis branch February 7, 2017 15:00
@PeterKietzmann PeterKietzmann added the Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. label Feb 7, 2017
This was referenced Feb 8, 2017
Merged
Merged
@kYc0o kYc0o mentioned this pull request Apr 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfischer-no jfischer-no jfischer-no left review comments

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

Assignees

@PeterKietzmann PeterKietzmann

@jfischer-no jfischer-no

Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smlng @jfischer-no @PeterKietzmann @OlegHahm