Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/lpc11u34: fixed ADC resolution selection #6959

Merged
merged 1 commit into from
Aug 24, 2017
Merged

cpu/lpc11u34: fixed ADC resolution selection #6959

merged 1 commit into from
Aug 24, 2017

Conversation

haukepetersen
Copy link
Contributor

fixes #5489 (or at least I hope so, don't have a board to test...)

@haukepetersen haukepetersen added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Apr 25, 2017
@haukepetersen haukepetersen added this to the Release 2017.07 milestone Apr 25, 2017
@haukepetersen haukepetersen mentioned this pull request Apr 25, 2017
Closed
jnohlgard
jnohlgard approved these changes May 31, 2017
View reviewed changes
Copy link
Member

@jnohlgard jnohlgard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I don't have a board with this CPU, but it looks right when I checked the manual for the CPU.

This CPU needs a bit of clean up with regards to magic numbers in the implementation, but that can be done in a separate PR.

@jnohlgard jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 31, 2017
@jnohlgard
Copy link
Member

Murdock2 is fine, @haukepetersen did you test this on actual hardware?

@haukepetersen
Copy link
Contributor Author

nope, I don't have this HW, and if I remember correctly nobody in Berlin/HH/Paris does...

@haukepetersen haukepetersen added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 20, 2017
@haukepetersen
cpu/lpc11u34: fixed ADC driver
ae3f019 
- fixed selection of resolution
- fixed result masking
- fixed channel selection (and optimized it)
- fixed clock prescaler calculation
@haukepetersen
Copy link
Contributor Author

actually, by looking at the driver once more, I found it broken in many more ways (and it seems to have been broken from the beginning as I see it...). Hopefully all should be good now.

As nobody seems to have a board with this CPU, is anyone willing to give an untested ACK (maybe after sharply comparing the changes done to the reference manual, page 385 ff?!

@jnohlgard
Copy link
Member

@haukepetersen perhaps it is time to drop the support for this CPU, since nobody seem to have the board and there is little or no interest in the PRs related to it?

@haukepetersen
Copy link
Contributor Author

I send a private mail to Paul to check if he is still able to maintain the platform, so let's wait for his reply before dropping anything...

@haukepetersen haukepetersen added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 24, 2017
@haukepetersen
Copy link
Contributor Author

Got an answer a while ago: he will not be able to maintain the board in the near future and we is ok with removing the board for now. I propose the following: we merge this PR untested and remove the board in a next step, but by documenting it so it can be pulled back into master if a new maintainer is available.

@gebart you ok with this? If yes -> press merge :-)

@jnohlgard jnohlgard merged commit a905a88 into RIOT-OS:master Aug 24, 2017
@haukepetersen haukepetersen deleted the fix_lpc11u_adc branch August 25, 2017 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

Assignees

@jnohlgard jnohlgard

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2017.10
Development

Successfully merging this pull request may close these issues.

cpu/lpc11u34: ADC broken
3 participants
@haukepetersen @jnohlgard @aabadie