-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: add stm32f769 discovery #7051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments regarding doxygen and LED configuration. Otherwise the changes look good but I don't have this board for testing.
|
||
/** | ||
* @name LED pin definitions | ||
* @{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doxygen comments look weird in this file.
#define LED2_MASK (1 << 12) | ||
#define LED3_MASK (1 << 4) | ||
|
||
#define LED0_ON (LED_PORT->BSRR = LED0_MASK) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LED_PORT => LED0_PORT ?
same comment for LED1 and LED2
|
||
#define LED3_ON (LED_PORT->BSRR = LED3_MASK) | ||
#define LED3_OFF (LED_PORT->BSRR = (LED3_MASK << 16)) | ||
#define LED3_TOGGLE (LED_PORT->ODR ^= LED3_MASK) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are 4 LEDs why not adding the fourth one in board_init ?
Copy/paste are evil! @aabadie, comments addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested ACK
6b9c048
to
1c637da
Compare
Fixed vendor header trailing white spaces and squashed. |
Murdock issue most likely unrelated, see #7069. |
All green, go ! |
This add basic support of stm32f769 discovery board and cpu (board manual here ). UART, LED and button works as expected, with SAUL support.
It also adds stm32f7 support in the RTC driver.