Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/fmt: Fix unintentional pointer advancement for negative numbers in fmt_float #7221

Merged
merged 1 commit into from
Jun 22, 2017
Merged

sys/fmt: Fix unintentional pointer advancement for negative numbers in fmt_float #7221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sys/fmt/fmt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,12 +274,11 @@ size_t fmt_float(char *out, float f, unsigned precision)

uint32_t fraction = f * _tenmap[precision];

size_t res = negative;
if (negative && out) {
*out++ = '-';
}

res += fmt_u32_dec(out, integer);
size_t res = fmt_u32_dec(out, integer);
if (precision && fraction) {
if (out) {
out += res;
Expand All @@ -289,6 +288,7 @@ size_t fmt_float(char *out, float f, unsigned precision)
}
res += (1 + precision);
}
res += negative;

return res;
}
Expand Down