kinetis: Add support for LPUART module in parallel with UART module #7362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnohlgard
added
Platform: ARM
This was referenced Jul 14, 2017
|
On first sight, the changes look legid to me. I will take a final look at the changes one #6994 is merged and this PR is rebased |
|
Ah, and by the way thanks for splitting those PRs! |
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
from
b19f9cd to
977444d
Compare
|
rebased |
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
from
977444d to
318abd9
Compare
|
ping @haukepetersen |
jnohlgard
added
the
CI: ready for build
|
(CI was idle) |
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
2 times, most recently
from
e2affdc to
cd94f6f
Compare
|
Updated the UART mode handling to support LPUART as well |
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
2 times, most recently
from
8a08940 to
d76c429
Compare
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
from
d76c429 to
aaceb4f
Compare
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
2 times, most recently
from
41fd2d8 to
1ea99ef
Compare
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
from
1ea99ef to
41ab608
Compare
|
@gebart so is the whole cluster of PRs ready for review from your perspective? |
|
This PR and the board+CPU PR is ready IMO. The transceiver driver has been stable in my tests, but there may be some clean up needed yet. |
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
2 times, most recently
from
f9d2e3d to
a2da73b
Compare
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
2 times, most recently
from
6b64133 to
531243f
Compare
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
from
531243f to
e3a322d
Compare
|
@haukepetersen @emmanuelsearch This is ready for review. This is currently blocking #6995 and #7107, and it's a general pain to keep basing all my other working branches on this PR. |
A dispatcher function is implemented for directing writes to the correct function. The dispatcher is bypassed completely if the CPU only contain one kind of UART module. There are at least two different UART hardware modules deployed in different Kinetis CPU families (or possibly three or more when counting variations of the UART module). The UART module is an older 8 bit module with advanced functionality, while the LPUART is a 32 bit module with focus on low power consumption. - The older families in the K series all have UART modules. - The K22F family have both UART and LPUART modules in the same CPU. - Older L series (e.g. KL25Z) have two variations of the UART module - Newer L series (e.g. KL43Z) have LPUART modules, and sometimes UART as well. - Newer W series (KW41Z) have only LPUART
jnohlgard
force-pushed
the
pr/kinetis-lpuart
branch
from
e3a322d to
00a0740
Compare
|
I have tested and reviewed what I can and found no issues so far. |
kYc0o
added
CI: ready for build
|
Re-trigger murdock just in case... |
|
Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
#6994Split from #6994 to make the review easier.
A dispatcher function is implemented for directing writes to the correct
function. The dispatcher is bypassed completely if the CPU only contain
one kind of UART module.
There are at least two different UART hardware modules deployed in
different Kinetis CPU families (or possibly three or more when counting
variations of the UART module). The UART module is an older 8 bit module
with advanced functionality, while the LPUART is a 32 bit module with
focus on low power consumption.
UART as well.