Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu, sam0_common: fix flashpage use bitfield #7644

Merged
merged 1 commit into from
Oct 13, 2017
Merged

cpu, sam0_common: fix flashpage use bitfield #7644

merged 1 commit into from
Oct 13, 2017

Conversation

smlng
Copy link
Member

@smlng smlng commented Sep 25, 2017 •
edited
Loading

@PeterKietzmann PR example for bachelor project

[edit:] nevertheless, a real PR and good to merge

@smlng smlng added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Sep 25, 2017
@smlng smlng self-assigned this Sep 25, 2017
@smlng
Copy link
Member Author

smlng commented Sep 25, 2017

followup on #7638, but also see discussion in #7641

@smlng smlng changed the title [WIP] cpu, sam0_common: fix flashpage use bitfield cpu, sam0_common: fix flashpage use bitfield Sep 25, 2017
@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 25, 2017
@smlng smlng mentioned this pull request Oct 10, 2017
Merged
@smlng smlng requested a review from haukepetersen October 10, 2017 15:33
haukepetersen
haukepetersen approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example ACK (but also really valid)

@miri64
Copy link
Member

miri64 commented Oct 13, 2017

Then I guess I examplify a go, since the CI test passed!

@miri64 miri64 merged commit 6e8fc5c into RIOT-OS:master Oct 13, 2017
@smlng smlng deleted the cpu/sam0/flashpage branch October 16, 2017 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haukepetersen haukepetersen haukepetersen approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

Assignees

@smlng smlng

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smlng @miri64 @haukepetersen