Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/driver_servo/main.c: fix var len #7852

Merged
merged 1 commit into from
Oct 26, 2017
Merged

tests/driver_servo/main.c: fix var len #7852

merged 1 commit into from
Oct 26, 2017

Conversation

kYc0o
Copy link
Contributor

@kYc0o kYc0o commented Oct 26, 2017

While compiling tests/driver_servo with clang in OS X it discovers several minor issues.

This PR fixes them.

@kYc0o kYc0o added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Area: tests Area: tests and testing framework labels Oct 26, 2017
@kYc0o kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 26, 2017
jnohlgard
jnohlgard approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this fixes a compilation error I don't mind. It should not affect the behavior of the test in any way.

@kYc0o
Copy link
Contributor Author

kYc0o commented Oct 26, 2017

Yes it's just compilation issues raised by clang. My efforts are towards #1121.

@kYc0o kYc0o merged commit 250fce1 into RIOT-OS:master Oct 26, 2017
@kYc0o kYc0o mentioned this pull request Oct 26, 2017
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

Assignees

@jnohlgard jnohlgard

Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kYc0o @jnohlgard