Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/relic: disable newline-eof compile error #8412

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

smlng
Copy link
Member

@smlng smlng commented Jan 23, 2018

Contribution description

Intermediate fix (package should be update anyways) for following error:

[ 64%] Building C object src/CMakeFiles/relic_s.dir/cp/relic_cp_ecdsa.c.obj
[ 65%] Building C object src/CMakeFiles/relic_s.dir/cp/relic_cp_ecss.c.obj
[ 66%] Building C object src/CMakeFiles/relic_s.dir/cp/relic_cp_vbnn_ibs.c.obj
/root/RIOT/tests/unittests/bin/pkg/native/relic/src/cp/relic_cp_vbnn_ibs.c:328:2: error: no newline at end of file [-Werror,-Wnewline-eof]
}
 ^
1 error generated.
src/CMakeFiles/relic_s.dir/build.make:1502: recipe for target 'src/CMakeFiles/relic_s.dir/cp/relic_cp_vbnn_ibs.c.obj' failed

Issues/PRs references

package update in #6965

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 23, 2018
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@smlng
Copy link
Member Author

smlng commented Jan 23, 2018

reported by clang on Ubuntu 16.04

cd tests/unittests
TOOLCHAIN=clang BOARDS=native make tests-relic

@miri64
Copy link
Member

miri64 commented Jan 23, 2018

Does this require a backport?

@miri64 miri64 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Jan 23, 2018
@smlng
Copy link
Member Author

smlng commented Jan 23, 2018

root@808fb508ff3c:~/RIOT/tests/unittests# clang --version
clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@miri64
Copy link
Member

miri64 commented Jan 23, 2018

(if not remove flag, please)

@smlng
Copy link
Member Author

smlng commented Jan 23, 2018

Does this require a backport?

Though we do not have clang as mandatory, I'm working on fixing clang and gcc 7.2 for this release. So yes, will do.

@miri64 miri64 merged commit ae437cd into RIOT-OS:master Jan 23, 2018
@miri64 miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Jan 26, 2018
@smlng smlng deleted the pkg/relic/fix_newline-eof branch February 6, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants