kinetis: Allow per-board config of ADC ref #8560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADC reference can be external pin or internal VREF module on most Kinetis CPUs.
jnohlgard
added
Type: enhancement
smlng
approved these changes
Feb 15, 2018
There was a problem hiding this comment.
ACK, no (big) magic happening here, still successfully tested ADC with pba-01-kw2x -> works.
We might consider to put allowed values into to the respective cpu.conf and set a reasonable default per board, thereby omitting the magic 0 and duplicated documentation above here.
|
Thank you @smlng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
ADC reference can be external pin or internal VREF module on most Kinetis CPUs. The CPU reference manual has a description of the valid values for each CPU, but I have added a short summary of the options in each of the existing periph_conf.h headers for reference.
This was previously hard-coded to always use reference setting 0, but for the FRDM-KW41Z board we need to use setting 1 to get valid ADC readings without always having VREF enabled (which would increase power consumption)
Issues/PRs references
Required by #6995