-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: Use ld -r for intermediate linking of each module #8711
Changes from all commits
17bae06
a7befdb
c6991d7
c0c9288
ddb5d87
2ee9d0b
4eaf7cd
b4afd66
86d5f31
43f9a43
95e8559
b61ecae
b305094
abb1374
79c666f
cc4e6dd
1886161
976b014
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,6 +46,8 @@ extern char _sheap; /* start of the heap */ | |
extern char _eheap; /* end of the heap */ | ||
char *heap_top = &_sheap + 4; | ||
|
||
/* MIPS newlib crt implements _init,_fini and _exit and manages the heap */ | ||
#ifndef __mips__ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @cladmi do you mean that this should be forked off? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If possible yes, also with the related changes in I think it would would help comparing the size change between master and this one as it is my main way of debugging currently. |
||
/** | ||
* @brief Free resources on NewLib de-initialization, not used for RIOT | ||
*/ | ||
|
@@ -98,6 +100,8 @@ void *_sbrk_r(struct _reent *r, ptrdiff_t incr) | |
return res; | ||
} | ||
|
||
#endif /*__mips__*/ | ||
|
||
/** | ||
* @brief Get the process-ID of the current thread | ||
* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,6 @@ SCANBUILD_ENV_VARS := \ | |
RIOT_CI_BUILD \ | ||
SIZE \ | ||
TOOLCHAIN \ | ||
UNDEF \ | ||
USER \ | ||
# | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,7 @@ | ||
INCLUDES += -I$(PKGDIRBASE)/jerryscript/jerry-core/include | ||
INCLUDES += -I$(PKGDIRBASE)/jerryscript/jerry-ext/include | ||
|
||
# the jerryscript build produces static archives | ||
LIBS += jerryscript | ||
LIBS += jerryscript-ext | ||
LIBS += jerryport-minimal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that using a generic empty.o will work. If I'm not mistaken (I did not test it), the linker will reject an object file if it's not the right architecture.
I guess something like that would be more robust:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, try it. It is the correct architecture because of using the real CFLAGS when generating it.
Not sure the ifeq suggestion is robust because of lazy evaluation of recursive variables, does OBJ always have its final value when interpreting this makefile?