tests/periph_flashpage: small cleanup #8770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Area: tests
kYc0o
requested changes
Mar 13, 2018
tests/periph_flashpage/main.c
Outdated
| @@ -283,8 +283,8 @@ static const shell_command_t shell_commands[] = { | |||
| { "info", "Show information about pages", cmd_info }, | |||
| { "dump", "Dump the selected page to STDOUT", cmd_dump }, | |||
| { "dump_local", "Dump the local page buffer to STDOUT", cmd_dump_local }, | |||
| { "read", "Read and output the given page", cmd_read }, | |||
| { "write", "Write (ASCII) data to the given page", cmd_write }, | |||
| { "read", "Copy the given page to the local page and dump to STDOUT", cmd_read }, | |||
There was a problem hiding this comment.
I'd say there's no local "page" but ram "buffer"... I suggest:
Load the given page into RAM and dump it to STDOUT.
tests/periph_flashpage/main.c
Outdated
| { "read", "Read and output the given page", cmd_read }, | ||
| { "write", "Write (ASCII) data to the given page", cmd_write }, | ||
| { "read", "Copy the given page to the local page and dump to STDOUT", cmd_read }, | ||
| { "write", "Write the local page buffer to the given page", cmd_write }, |
There was a problem hiding this comment.
Here I'd say ASCII is important. I suggest:
Write (ASCII) data from RAM buffer into the given page
aabadie
force-pushed
the
pr/tests/flashpage
branch
from
9d4425f to
c5aba69
Compare
|
@kYc0o, I changed slightly my first approach and used |
cladmi
approved these changes
Mar 15, 2018
|
@kYc0o, do you ACK ? |
A-Paul
reviewed
Mar 15, 2018
tests/periph_flashpage/README.md
Outdated
| @@ -34,5 +34,5 @@ What else to check: | |||
|
|
|||
| Background | |||
| ========== | |||
| This test provides you with tools to test implementations of the `flashpage` | |||
| peripheral driver interface. | |||
| This test provides tools to test implementations of the `flashpage` peripheral | |||
There was a problem hiding this comment.
test ... to test
Seems somewhat redundant. :-)
What about "This shell provides commands to test ...."?
There was a problem hiding this comment.
Not exactly your suggestion, but I just pushed an update of this.
aabadie
force-pushed
the
pr/tests/flashpage
branch
from
c5aba69 to
890cec3
Compare
kaspar030
approved these changes
Mar 16, 2018
|
@kYc0o, just missing your ACK here |
kYc0o
approved these changes
Mar 16, 2018
|
ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR makes some cleanup in the
tests/periph_flashpageapplication. While working on #8768, I had trouble with some misleading outputs/command help.Issues/PRs references
None