Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg*: replace curly braces by parenthesis in makefiles #8815

Merged
merged 1 commit into from
Mar 22, 2018
Merged

pkg*: replace curly braces by parenthesis in makefiles #8815

merged 1 commit into from
Mar 22, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Mar 22, 2018

Contribution description

This PR simply use the right way of accessing variables in makefiles, as suggested in this comment.

This PR only addresses the packages makefiles, but using git grep, there are other places in the code that need to be addressed as well.

Issues/PRs references

@aabadie aabadie added Area: build system Area: Build system Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 22, 2018
jnohlgard
jnohlgard approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie aabadie merged commit 7f91bfe into RIOT-OS:master Mar 22, 2018
@aabadie aabadie mentioned this pull request Mar 22, 2018
Merged
@aabadie aabadie deleted the pr/pkg/cleanup_makefile branch June 8, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @jnohlgard