Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: gnrc_sixlowpan: replace default netif with dummy #9648

Merged
merged 1 commit into from
Jul 31, 2018
Merged

tests: gnrc_sixlowpan: replace default netif with dummy #9648

merged 1 commit into from
Jul 31, 2018

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 30, 2018

Contribution description

Use a minimalistic dummy instead of the default interface for testing
the gnrc_sixlowpan module

Currently the default interface is used which leads to problems with
this test, since random traffic on the medium might lead to failed
results.

Issues/PRs references

None

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: tests Area: tests and testing framework GNRC Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Jul 30, 2018
@miri64 miri64 added this to the Release 2018.07 milestone Jul 30, 2018
@miri64 miri64 requested a review from cladmi July 30, 2018 15:17
@cladmi cladmi requested review from jcarrano and jia200x July 30, 2018 15:48
@cladmi
Copy link
Contributor

cladmi commented Jul 30, 2018 •
edited
Loading

I do not have the Segmentation Fault on native anymore.
I do not have an assertion anymore on arduino-zero.

It now fails in the same way as on iotlab-m3 and samr21-xpro with a timeout for child.expect_exact("tag: 0x1"), which is an improvement.

@jia200x and @jcarrano could you also test this PR as it was producing hardfault and assertion failed on the board you tested: RIOT-OS/Release-Specs#65 (comment)

@miri64
Copy link
Member Author

miri64 commented Jul 30, 2018

It now fails in the same way as on iotlab-m3 and samr21-xpro with a timeout for child.expect_exact("tag: 0x1"), which is an improvement.

On native I can't reproduce that.

@cladmi
Copy link
Contributor

cladmi commented Jul 30, 2018

On native I can't reproduce that.

It is failing reliably on my side so it could help debugging.

@miri64
Copy link
Member Author

miri64 commented Jul 30, 2018

I think I fixed it: #9649

@cladmi cladmi mentioned this pull request Jul 31, 2018
Merged
@miri64 miri64 force-pushed the tests/fix/gnrc_sixlowpan-dummy branch from a15c342 to 94cd178 Compare July 31, 2018 14:41
@miri64
Copy link
Member Author

miri64 commented Jul 31, 2018

Rebased to current master to include #9649.

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR and removed CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 31, 2018
miri64
miri64 commented Jul 31, 2018
View reviewed changes
tests/gnrc_sixlowpan/Makefile Outdated
nucleo-f031k6 nucleo-f042k6 nucleo-f070rb \
nucleo-f070rb nucleo-f303k8 nucleo-f334r8 \
nucleo-l031k6 nucleo-l053r8 stm32f0discovery \
telosb wsn430-v1_3b wsn430-v1_4 z1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hifive1 and nuclo-f072rb were added, because previously they did not pull in a radio, so now with the dummy device the RAM overflows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, actually missed to add the nucleo-f072rb

@miri64 miri64 mentioned this pull request Jul 31, 2018
Merged
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 31, 2018
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 31, 2018
cladmi
cladmi approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@cladmi cladmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test worked in #9650 on murdock even if it failed to report status. Please squash.

@miri64
tests: gnrc_sixlowpan: replace default netif with dummy
6c2510d 
Use a minimalistic dummy instead of the default interface for testing
the `gnrc_sixlowpan` module

Currently the default interface is used which leads to problems with
this test, since random traffic on the medium might lead to failed
results.
@miri64 miri64 force-pushed the tests/fix/gnrc_sixlowpan-dummy branch from a083e0f to 6c2510d Compare July 31, 2018 18:59
@miri64
Copy link
Member Author

miri64 commented Jul 31, 2018

Squashed

@miri64 miri64 merged commit 5ea5904 into RIOT-OS:master Jul 31, 2018
@miri64 miri64 deleted the tests/fix/gnrc_sixlowpan-dummy branch July 31, 2018 20:01
@miri64 miri64 mentioned this pull request Aug 1, 2018
Merged
@cladmi cladmi mentioned this pull request Aug 1, 2018
Merged
@miri64 miri64 mentioned this pull request Aug 1, 2018
Merged
@miri64
Copy link
Member Author

miri64 commented Aug 1, 2018

Backport provided in #9676.

@miri64 miri64 mentioned this pull request Sep 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cladmi cladmi cladmi approved these changes

@jcarrano jcarrano Awaiting requested review from jcarrano

@jia200x jia200x Awaiting requested review from jia200x

Assignees
No one assigned
Labels
Area: network Area: Networking Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.07
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @cladmi