Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: blacklist selected pkgs for LLVM/clang #9734

Merged
merged 5 commits into from
Sep 21, 2018
Merged

pkg: blacklist selected pkgs for LLVM/clang #9734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5aaa0b2
micro-ecc: blacklist LLVM/clang
miri64 Aug 7, 2018
14eb760
openthread: blacklist LLVM/clang
miri64 Aug 7, 2018
6a56be5
nrf_softdevice_ble: blacklist LLVM/clang
miri64 Aug 8, 2018
ed5dde0
qDSA: blacklist LLVM/clang
miri64 Aug 16, 2018
58f7150
jerryscript: blacklist LLVM/clang
miri64 Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/jerryscript/Makefile.include
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
INCLUDES += -I$(PKGDIRBASE)/jerryscript/jerry-core/include
INCLUDES += -I$(PKGDIRBASE)/jerryscript/jerry-ext/include

ifneq (,$(filter cortex-m%,$(CPU_ARCH)))
# jerryscript package package is not using system includes right now, so
# many newlib hearders (not even stdio.h) is found
# Fixed in #9821 (so remove when merged)
TOOLCHAINS_BLACKLIST += llvm
endif
6 changes: 6 additions & 0 deletions pkg/micro-ecc/Makefile.include
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
INCLUDES += -I$(PKGDIRBASE)/micro-ecc

ifneq (,$(filter cortex-m0%,$(CPU_ARCH)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it fails for samr21-xpro in tests/pkg_micro-ecc.

# LLVM/clang can't handle the inline assembler instructions on M0 in this
# package
TOOLCHAINS_BLACKLIST += llvm
endif
3 changes: 3 additions & 0 deletions pkg/nordic_softdevice_ble/Makefile.include
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ DIRS += \
$(NORDIC_SRCS)/components/softdevice/common/softdevice_handler \
$(NORDIC_SRCS)/components/ble/common \
$(NORDIC_SRCS)/components/iot/ble_ipsp

# LLVM ARM assembler has massive problems digesting this
TOOLCHAINS_BLACKLIST += llvm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it fails for examples/gnrc_networking on nrf52dk.

6 changes: 6 additions & 0 deletions pkg/openthread/Makefile.include
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,9 @@ ifneq (,$(filter openthread_contrib,$(USEMODULE)))
DIRS += $(OPENTHREAD_DIR)/contrib
DIRS += $(OPENTHREAD_DIR)/contrib/netdev
endif

ifneq (,$(filter cortex-m0% cortex-m3%,$(CPU_ARCH)))
# There are problem with unused `-mcpu...` arguments in clang and with
# ranlib + LLVM/clang in this package with Cortex-M0 and M3
TOOLCHAINS_BLACKLIST += llvm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the same for pkg/openthread with samr21-xpro and iotlab-m3

endif
6 changes: 6 additions & 0 deletions pkg/qDSA/Makefile.include
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,9 @@ endif
export QDSA_IMPL

INCLUDES += -I$(PKGDIRBASE)/qDSA/$(QDSA_IMPL)

ifeq (cortex-m0plus,$(CPU_ARCH))
# There are problems with the LLVM assembler and the Cortex-M0+ instruction
# set with this package
TOOLCHAINS_BLACKLIST += llvm
endif