tests/unittests: test black corner case for color_rgb2hsv() #9940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: enhancement
jnohlgard
previously requested changes
Sep 15, 2018
|
Mostly FYI in the case someone is interested. I converted the HSV data structures partially into fixed point, since I suspected that floats could have caused instability. The result is in this commit: It is not ready to land, but maybe someone wants to pick it up or have a look at it. I am not planning to continue with it; if anyone feels like grabbing, please go ahead. |
miri64
force-pushed
the
tests/enh/rgb2hsv-black
branch
from
c00573c to
5dbb1a1
Compare
|
@gebart I adapted the PR according to @pekkanikander's proposal. Can you have another look? |
|
@kaspar030 could you maybe have a look at this :-/? |
|
@benpicco you want to maybe have a look at this 😁? |
|
It should suffice to test if
|
|
True, but that doesn't test the case this PR was originally introduced for: #9939 |
|
Well technically they could be any random value… Maybe someone comes up with a better implementation where it's left uninitialized, that would still be valid. |
so what are you asking? |
|
I'd remove the test for |
|
Done |
|
Looks good, please squash! |
benpicco
approved these changes
Sep 27, 2019
Tests a (currently undocumented) behavior of `color_rgb2hsv()`, that a black RGB value (all zero) causes the HSV value to be all zero.
miri64
force-pushed
the
tests/enh/rgb2hsv-black
branch
from
097fce0 to
2c9ac91
Compare
|
Squashed |
|
I believe @gebart's comments were addressed. |
|
tbh, comparing a |
bors bot
added a commit
that referenced
this pull request
Jun 5, 2023
19693: sys/color: extend unittest and fix module r=kfessel a=kfessel ### Contribution description this extends the unittest for sys_color testing more colors ### Testing procedure ``` RIOT_tree/tests/unittests$ make tests-color test ``` will fail since our `rgb2hsv` implementation is wrong (or is using an other colorspace than hsv2rgb (without documenting)) the new `hsv2rgb` test will succeed ### Issues/PRs references #19614 was the reason i had a look at this #1315 added the rgb2hsv and hsv2rgb function #9940 added the test for black special case https://www.vagrearg.org/content/hsvrgb << some optimization for that function (avoiding float) Co-authored-by: Karl Fessel <karl.fessel@ovgu.de>
bors bot
added a commit
that referenced
this pull request
Jun 5, 2023
19378: sys: add common imath module mv isin() form test/driver_dac_dds r=kfessel a=benpicco 19693: sys/color: extend unittest and fix module r=kfessel a=kfessel ### Contribution description this extends the unittest for sys_color testing more colors ### Testing procedure ``` RIOT_tree/tests/unittests$ make tests-color test ``` will fail since our `rgb2hsv` implementation is wrong (or is using an other colorspace than hsv2rgb (without documenting)) the new `hsv2rgb` test will succeed ### Issues/PRs references #19614 was the reason i had a look at this #1315 added the rgb2hsv and hsv2rgb function #9940 added the test for black special case https://www.vagrearg.org/content/hsvrgb << some optimization for that function (avoiding float) Co-authored-by: Benjamin Valentin <benpicco@beuth-hochschule.de> Co-authored-by: Karl Fessel <karl.fessel@ovgu.de>
bors bot
added a commit
that referenced
this pull request
Jun 5, 2023
19378: sys: add common imath module mv isin() form test/driver_dac_dds r=maribu a=benpicco 19693: sys/color: extend unittest and fix module r=kfessel a=kfessel ### Contribution description this extends the unittest for sys_color testing more colors ### Testing procedure ``` RIOT_tree/tests/unittests$ make tests-color test ``` will fail since our `rgb2hsv` implementation is wrong (or is using an other colorspace than hsv2rgb (without documenting)) the new `hsv2rgb` test will succeed ### Issues/PRs references #19614 was the reason i had a look at this #1315 added the rgb2hsv and hsv2rgb function #9940 added the test for black special case https://www.vagrearg.org/content/hsvrgb << some optimization for that function (avoiding float) Co-authored-by: Benjamin Valentin <benpicco@beuth-hochschule.de> Co-authored-by: Karl Fessel <karl.fessel@ovgu.de>
bors bot
added a commit
that referenced
this pull request
Jun 5, 2023
19693: sys/color: extend unittest and fix module r=kfessel a=kfessel ### Contribution description this extends the unittest for sys_color testing more colors ### Testing procedure ``` RIOT_tree/tests/unittests$ make tests-color test ``` will fail since our `rgb2hsv` implementation is wrong (or is using an other colorspace than hsv2rgb (without documenting)) the new `hsv2rgb` test will succeed ### Issues/PRs references #19614 was the reason i had a look at this #1315 added the rgb2hsv and hsv2rgb function #9940 added the test for black special case https://www.vagrearg.org/content/hsvrgb << some optimization for that function (avoiding float) Co-authored-by: Karl Fessel <karl.fessel@ovgu.de>
bors bot
added a commit
that referenced
this pull request
Jun 6, 2023
19693: sys/color: extend unittest and fix module r=maribu a=kfessel ### Contribution description this extends the unittest for sys_color testing more colors ### Testing procedure ``` RIOT_tree/tests/unittests$ make tests-color test ``` will fail since our `rgb2hsv` implementation is wrong (or is using an other colorspace than hsv2rgb (without documenting)) the new `hsv2rgb` test will succeed ### Issues/PRs references #19614 was the reason i had a look at this #1315 added the rgb2hsv and hsv2rgb function #9940 added the test for black special case https://www.vagrearg.org/content/hsvrgb << some optimization for that function (avoiding float) Co-authored-by: Karl Fessel <karl.fessel@ovgu.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Tests a (currently undocumented) behavior of
color_rgb2hsv(), that ablack RGB value (all zero) causes the HSV value to be all zero.
Testing procedure
Run the unittests for
color(make -C tests/unittests tests-color test). With current master they will fail, but #9939 fixes them.Issues/PRs references
Requires #9939 for the test to succeed.