-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/atmega_common: refactor AVR libc code into module #9984
Conversation
4f20403
to
3edd7b4
Compare
@kYc0o care to take a look at this? |
here is the new static-tests output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, tested on Arduino-Mega2560. Confirm it still works and size(s) stay the same! Murdock error is (very) likely unrelated.
can someone else please verify this, too: @MrKevinWeiss @leandrolanzieri? Just to be sure |
@kaspar030 please squash if Murdock is happy |
running tests now |
Both master and this PR fail the same tests using @cladmi compile_and_test_for_board.py script
|
Maybe this can come after #9130 ? |
I think the order is not important, its more a matter of who needs to rebase (and maybe manual merge stuff) later on 😄 |
3edd7b4
to
7313525
Compare
Can this be considered minor impact regarding the freeze? |
reACK, tested with arduino-mega2560 and several different test applications: all good. Also tested with Arduino-uno, same same. GO! |
Yes and no. #8857 updated vendor files and moved them from Having |
This PR refactors atmega libc specific code and compatibility headers into a
subfolder.
Test if CI still builds, sizes stay same.