Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/atmega_common: refactor AVR libc code into module #9984

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

kaspar030
Copy link
Contributor

This PR refactors atmega libc specific code and compatibility headers into a
subfolder.

Test if CI still builds, sizes stay same.

@kaspar030 kaspar030 requested a review from cladmi September 20, 2018 21:45
@kaspar030 kaspar030 added Platform: AVR Platform: This PR/issue effects AVR-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 20, 2018
@kYc0o kYc0o self-assigned this Oct 10, 2018
@kaspar030 kaspar030 force-pushed the refactor_atmega_libc branch from 4f20403 to 3edd7b4 Compare November 28, 2018 19:37
@kaspar030
Copy link
Contributor Author

  • rebased

@kYc0o care to take a look at this?

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 28, 2018
@kaspar030
Copy link
Contributor Author

here is the new static-tests output.

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 28, 2018
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, tested on Arduino-Mega2560. Confirm it still works and size(s) stay the same! Murdock error is (very) likely unrelated.

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 19, 2018
@smlng smlng requested a review from MrKevinWeiss December 19, 2018 08:48
@smlng
Copy link
Member

smlng commented Dec 19, 2018

can someone else please verify this, too: @MrKevinWeiss @leandrolanzieri? Just to be sure

@smlng
Copy link
Member

smlng commented Dec 19, 2018

@kaspar030 please squash if Murdock is happy

@MrKevinWeiss
Copy link
Contributor

running tests now

@MrKevinWeiss
Copy link
Contributor

Both master and this PR fail the same tests using @cladmi compile_and_test_for_board.py script

Failures during test:
- [tests/bench_runtime_coreapis](tests/bench_runtime_coreapis/test.failed)
- [tests/bitarithm_timings](tests/bitarithm_timings/test.failed)
- [tests/evtimer_msg](tests/evtimer_msg/test.failed)
- [tests/isr_yield_higher](tests/isr_yield_higher/test.failed)
- [tests/libfixmath](tests/libfixmath/test.failed)
- [tests/periph_eeprom](tests/periph_eeprom/test.failed)
- [tests/periph_gpio](tests/periph_gpio/test.failed)
- [tests/pipe](tests/pipe/test.failed)
- [tests/pkg_fatfs_vfs](tests/pkg_fatfs_vfs/test.failed)
- [tests/pkg_jsmn](tests/pkg_jsmn/test.failed)
- [tests/pkg_libb2](tests/pkg_libb2/test.failed)
- [tests/pkg_lora-serialization](tests/pkg_lora-serialization/test.failed)
- [tests/pkg_micro-ecc](tests/pkg_micro-ecc/test.failed)
- [tests/pkg_tiny-asn1](tests/pkg_tiny-asn1/test.failed)
- [tests/posix_semaphore](tests/posix_semaphore/test.failed)
- [tests/ps_schedstatistics](tests/ps_schedstatistics/test.failed)
- [tests/rng](tests/rng/test.failed)
- [tests/trickle](tests/trickle/test.failed)

@kYc0o
Copy link
Contributor

kYc0o commented Jan 7, 2019

Maybe this can come after #9130 ?

@smlng
Copy link
Member

smlng commented Jan 8, 2019

Maybe this can come after #9130 ?

I think the order is not important, its more a matter of who needs to rebase (and maybe manual merge stuff) later on 😄

@kaspar030 kaspar030 force-pushed the refactor_atmega_libc branch from 3edd7b4 to 7313525 Compare January 21, 2019 13:37
@kaspar030
Copy link
Contributor Author

  • squashed

Can this be considered minor impact regarding the freeze?

@smlng
Copy link
Member

smlng commented Jan 22, 2019

reACK, tested with arduino-mega2560 and several different test applications: all good. Also tested with Arduino-uno, same same. GO!

@smlng smlng merged commit 0edf76d into RIOT-OS:master Jan 22, 2019
@miri64
Copy link
Member

miri64 commented Jan 22, 2019

Am I right to understand that this PR reverts parts of #8857 (specifically b597700)?

@kaspar030
Copy link
Contributor Author

Am I right to understand that this PR reverts parts of #8857 (specifically b597700)?

Yes and no. #8857 updated vendor files and moved them from avr-libc-extra/include into include/vendor in order to keep CI from checking them. This PR re-introduces avr-libc-extra/ but also adds a vendor/ subfolder.

Having avr-libc-extra doesn't make sense as is (if all AVR boards always use the avr libc), but is a first step towards either not using a libc at all or using a different one.

@kaspar030 kaspar030 deleted the refactor_atmega_libc branch January 22, 2019 10:13
@aabadie aabadie added this to the Release 2019.01 milestone Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants