Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task04: add ICMPv6 stress test #90

Merged
merged 1 commit into from
Jan 22, 2019
Merged

task04: add ICMPv6 stress test #90

merged 1 commit into from
Jan 22, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 16, 2019

This test is aiming to detect regressions to RIOT-OS/RIOT#10672 and RIOT-OS/RIOT#10701.


### Result

All nodes are still running, reachable, and the packet buffer is empty 3 seconds
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 seconds because that is the time a fragmented datagram might stay in 6LoWPAN's reassembly buffer before completion is given up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you determine that the packet buffer is empty ? I tried pktbuf and it returns:

> pktbuf
pktbuf
packet buffer: first byte: 0x20001b18, last byte: 0x20003318 (size: 6144)
  position of last byte used: 1672
~ unused: 0x20001b18 (next: 0, size: 6144) ~

I guess the unused means it's empty ?

Copy link
Member Author

@miri64 miri64 Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but the size and position of the unused space [edit](and the fact that there is only one)[/edit] gives you a hint that it is empty: It is at the start of the packet buffer (equals first byte:), its size is equal to the size of the packet buffer ((size: 6144) on top, and its next pointer points to NULL. If data would be in the packet buffer you would see several unused spaces with the data as a hex dump in between those spaces. I guess once you saw the filled state you would know what empty is ;-).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(try pktbuf on the pinged node while it is pinged; you most likely will see what I mean)

Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK and go

@aabadie aabadie merged commit 5b83764 into master Jan 22, 2019
@miri64 miri64 deleted the task04/stresstest branch January 22, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants