Update CoAP crates to work without declaring any nightly features #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2022
chrysn
force-pushed
the
update-coap-crates-to-post-feature
branch
from
3a62339 to
aabca98
Compare
In cases like the current PR this is essential -- otherwise, if either of them has increased its dependencies, the override will be ignored fully, and the older release is used instead.
chrysn
force-pushed
the
update-coap-crates-to-post-feature
branch
from
68dba89 to
efee68a
Compare
|
Blocked until RIOT-OS/riotdocker#207 is through. |
bors bot
added a commit
to RIOT-OS/riotdocker
that referenced
this pull request
Sep 26, 2022
207: rust: Update nightly version r=kaspar030 a=chrysn This is what #204 should have been, but as that nightly build did not contain that day's rustc, the intended version was not installed. --- I did tests back in #204, but they were about "do they existing things still work", not (what I couldn't test easily back then, as it'd have spanned many crates at once) "does it also have the intended effect of allowing stable use of all the new features". This unblocks RIOT-OS/rust-riot-wrappers#14, and would have made the rollback of RIOT-OS/RIOT#18642 (comment) unnecessary. Co-authored-by: chrysn <chrysn@fsfe.org>
This simplifies the Cargo.toml as coap-numbers' alloc is now opt-in, and reduces duplication with the other CoAP crates which already use 0.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.