Allow for OmniAuth 2.0 series #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* One of the breaking changes in OmniAuth 2.0+ relates to how relative URL installations are handled. See: omniauth/omniauth#903 and https://github.com/omniauth/omniauth/wiki/Upgrading-to-2.0#relative-root-apps * As a result, when `azure_activedirectory_v2` is used with OmniAuth 2.0+ for an app that lives at a relative URl, the `#callback_url` is incorrect (the relative URL is included twice). * This is because OmniAuth is now prefixing the default Strategy#request_path and Strategy#callback_path with SCRIPT_NAME, but `azure_activedirectory_v2` is also adding `script_name` to `callback_url`. * This update makes this gem compatible with OmniAuth 2.0+ but will break relative URL installatons for OmniAuth 1.x so I've also updated the gemspec to rely on a version of omniauth-oauth2 that has a dependency on omniauth 2.0: omniauth/omniauth-oauth2#152 (comment) * Similar change to omniauth-google-oauth2 was made here: zquestz/omniauth-google-oauth2#403
jessieay
commented
Sep 7, 2022
| it 'should set the callback path with script_name if present' do | ||
| allow(subject).to receive(:full_host) { base_url } | ||
| allow(subject).to receive(:script_name) { '/v1' } | ||
| expect(subject.callback_url).to eq(base_url + '/v1/auth/azure_activedirectory_v2/callback') |
There was a problem hiding this comment.
this spec failed before I made the code changes:
jessieay
commented
Sep 7, 2022
| @@ -45,5 +45,5 @@ Gem::Specification.new do |s| | |||
| 'source_code_uri' => 'https://github.com/RIPGlobal/omniauth-azure-activedirectory-v2' | |||
| } | |||
|
|
|||
| s.add_runtime_dependency('omniauth-oauth2', '~> 1.7') | |||
| s.add_runtime_dependency('omniauth-oauth2', '~> 1.8') | |||
There was a problem hiding this comment.
this means that the gem is now dependent on omniauth 2.0. omniauth/omniauth-oauth2#152 (comment)
whithajess
approved these changes
Sep 13, 2022
Merged
|
Thanks @jessieay have bumped the version and pushed up to Rubygems - https://rubygems.org/gems/omniauth-azure-activedirectory-v2/versions/2.0.0 |
|
Thanks so much for merging and bumping @whithajess ! Much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure_activedirectory_v2is used with OmniAuth 2.0+ for an app that lives at a relative URl, the#callback_urlis incorrect (the relative URL is included twice).azure_activedirectory_v2is also addingscript_nametocallback_url.on omniauth 2.0: Use omniauth 2.x to ensure latest security updates omniauth/omniauth-oauth2#152 (comment)