Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com>
  • Loading branch information
neon60 and randyh62 authored Nov 9, 2024
1 parent e421cf4 commit 0a900a9
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions docs/how-to/hip_runtime_api/opengl_interop.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ OpenGL interoperability

The HIP--OpenGL interoperation involves mapping OpenGL resources, such as
buffers and textures, for HIP access. This mapping process enables HIP to
utilize these resources directly, bypassing the need for data transfers between
utilize these resources directly, bypassing the need for costly data transfers between
the CPU and GPU. This capability is useful in applications that require both
intensive GPU computation and real-time visualization.

Expand All @@ -36,20 +36,20 @@ framebuffer in a cycle until the window is not closed.
.. note::

The more recent recent OpenGL functions loaded with `OpenGL loader <https://github.com/ROCm/rocm-examples/tree/develop/External/glad>`_,
as these are not loaded by default on all platforms. The use of custom loader
as these are not loaded by default on all platforms. The use of a custom loader
shown in the following example

.. literalinclude:: ../../tools/example_codes/opengl_interop.hip
:start-after: // [Sphinx opengl functions load start]
:end-before: // [Sphinx opengl functions load end]

The OpenGL buffer is imported to HIP using as the following way:
The OpenGL buffer is imported to HIP in the following way:

.. literalinclude:: ../../tools/example_codes/opengl_interop.hip
:start-after: // [Sphinx buffer register and get start]
:end-before: // [Sphinx buffer register and get end]

The imported pointer manipulated in the sinewave kernel as the following way:
The imported pointer is manipulated in the sinewave kernel as shown in the following example:

.. literalinclude:: ../../tools/example_codes/opengl_interop.hip
:start-after: /// [Sphinx sinewave kernel start]
Expand All @@ -59,7 +59,7 @@ The imported pointer manipulated in the sinewave kernel as the following way:
:start-after: // [Sphinx buffer use in kernel start]
:end-before: // [Sphinx buffer use in kernel end]

The OpenGL buffer is imported to HIP using as the following way:
The OpenGL buffer is imported to HIP in the following way:

.. literalinclude:: ../../tools/example_codes/opengl_interop.hip
:start-after: // [Sphinx buffer register and get start]
Expand Down

0 comments on commit 0a900a9

Please sign in to comment.