SWDEV-466543 - Set BUILD_SHARED_LIBS flag in build_openmp script #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For static builds, linking to static libraries of drm and libdrm_amdgpu is required. Based on BUILD_SHARED_LIBS flag, thunk will link to static or shared library versions of drm/libdrm_amdgpu libraries
raramakr
requested review from
estewart08,
gregrodgers and
ronlieb
as code owners
|
Can we move this into the AOMP_STANDALONE_BUILD==0 condition below? |
Addressed the same |
estewart08
approved these changes
Jun 27, 2024
estewart08
pushed a commit
that referenced
this pull request
Jun 27, 2024
* SWDEV-466543 - Set BUILD_SHARED_LIBS flag in build_openmp script For static builds, linking to static libraries of drm and libdrm_amdgpu is required. Based on BUILD_SHARED_LIBS flag, thunk will link to static or shared library versions of drm/libdrm_amdgpu libraries * Limit the setting of BUILD_SHARED_LIBS to non aomp standalone build
rocm-ci
pushed a commit
that referenced
this pull request
Aug 2, 2024
* SWDEV-466543 - Set BUILD_SHARED_LIBS flag in build_openmp script For static builds, linking to static libraries of drm and libdrm_amdgpu is required. Based on BUILD_SHARED_LIBS flag, thunk will link to static or shared library versions of drm/libdrm_amdgpu libraries * Limit the setting of BUILD_SHARED_LIBS to non aomp standalone build Change-Id: I72dfca132743ab7fa01f3043d58c8bf313568d08
rocm-ci
pushed a commit
that referenced
this pull request
Aug 2, 2024
…pt (#960)" into release/rocm-rel-6.2
searlmc1
pushed a commit
that referenced
this pull request
Aug 23, 2024
* SWDEV-466543 - Set BUILD_SHARED_LIBS flag in build_openmp script For static builds, linking to static libraries of drm and libdrm_amdgpu is required. Based on BUILD_SHARED_LIBS flag, thunk will link to static or shared library versions of drm/libdrm_amdgpu libraries * Limit the setting of BUILD_SHARED_LIBS to non aomp standalone build Change-Id: I72dfca132743ab7fa01f3043d58c8bf313568d08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For static builds, linking to static libraries of drm and libdrm_amdgpu is required. Based on BUILD_SHARED_LIBS flag, thunk will link to static or shared library versions of drm/libdrm_amdgpu libraries