Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXSWHTEC-253 - Implement tests for coalesced_group basic APIs #154

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
cea96af
SWDEV-355313 - Move catch tests and samples
gargrahul Oct 26, 2022
909e7e4
SWDEV-355313 - Add README
gargrahul Nov 7, 2022
094b9af
SWDEV-355313 - Update amd-staging branch
gargrahul Nov 28, 2022
9daa6d0
SWDEV-355313 - Update README
gargrahul Dec 2, 2022
c49043e
SWDEV-355313 - Update latest code
gargrahul Dec 6, 2022
edf514a
Migrate basic Cooperative Groups tests and integrate to catch
nives-vukovic Jan 4, 2023
5610a48
Refactor basic Cooperative Groups tests
nives-vukovic Jan 10, 2023
c455740
Rename tiled partition related files and fix minor bug
nives-vukovic Jan 11, 2023
82fc666
Add LaunchCooperativeKernal and LaunchCooperativeKernelMultiDevice tests
nives-vukovic Jan 11, 2023
ef4fa46
Refactor hipCGThreadBlockTileType to use common function
nives-vukovic Jan 12, 2023
9c0f995
Merge remote-tracking branch 'origin/develop' into hipCoopGroups_wip
nives-vukovic Jan 12, 2023
b28aa60
Fix updated file not added during merge
nives-vukovic Jan 12, 2023
cc32117
Add coalesced_group type tests
nives-vukovic Jan 12, 2023
a177e26
Add coalesced_group shuffle_up and shuffle_down tests
nives-vukovic Jan 12, 2023
cdeadcf
Add coalesced_group shuffle tests - test fails
nives-vukovic Jan 13, 2023
7007d18
Introduce command line options.
mirza-halilcevic Jan 30, 2023
7b84ac1
Merge remote-tracking branch 'upstream/develop' into cg_base_dino
music-dino Feb 1, 2023
d414bce
Implement common code for cooperative group tests
music-dino Feb 1, 2023
609fae5
Fixed compilation errror in cooperative_groups_common.hh
music-dino Feb 1, 2023
8cfb58b
Implement busy wait device function
music-dino Feb 1, 2023
5cf02ca
Add thread and block dimensions generators
music-dino Feb 2, 2023
859f581
Implement command line options for cg sync extended runs
music-dino Feb 2, 2023
80c6c5c
EXSWHTEC-253 - Implement tests for coalesced_group basic APIs
nives-vukovic Feb 2, 2023
fb3b481
EXSWHTEC-253 - remove kernel getter for is_valid API
nives-vukovic Feb 2, 2023
bb41488
EXSWHTEC-253 - Expand delta range for shuffle tests
nives-vukovic Feb 3, 2023
b0d85b7
Merge remote-tracking branch 'origin/cmd_options' into cg_coalesced_g…
nives-vukovic Feb 6, 2023
8afe55e
EXSWHTEC-253 - Add command line options for sync test
nives-vukovic Feb 6, 2023
fc11bf9
Move cpu_grid.h and supporting functions to catch/include
nives-vukovic Mar 1, 2023
9e6ce3b
Merge remote-tracking branch 'origin/cg_base_dino' into cg_coalesced_…
nives-vukovic Mar 1, 2023
18f2450
Use warp_size from properties in grid/block dims generators
nives-vukovic Mar 1, 2023
3e26f62
Merge remote-tracking branch 'origin/cg_base_dino' into cg_coalesced_…
nives-vukovic Mar 1, 2023
65a1e57
Fix condition for warp size 32 on AMD
nives-vukovic Mar 1, 2023
c01665f
Fix cpu_grid.h for warp function tests
nives-vukovic Mar 2, 2023
e41e642
Add missing include into cpu_grid.h
nives-vukovic Mar 2, 2023
02306d5
Common code cleanup
nives-vukovic Mar 6, 2023
0dc1f01
Further common code cleanup
nives-vukovic Mar 6, 2023
e00fc23
Merge remote-tracking branch 'origin/cg_base_dino' into cg_coalesced_…
nives-vukovic Mar 6, 2023
2a177db
EXSWHTEC-253 - Fix doxygen comments
milos-mozetic Mar 23, 2023
090d46d
Rename --cg-extended-run option to --cg-iterations.
mirza-halilcevic May 15, 2023
d3477bd
Merge remote-tracking branch 'origin/cmd_options' into cg_coalesced_g…
mirza-halilcevic May 15, 2023
90e555a
Rename --cg-extended-run option to --cg-iterations.
mirza-halilcevic May 15, 2023
bcf88d1
Merge remote-tracking branch 'origin/develop' into cg_coalesced_group…
nives-vukovic Jul 12, 2023
a88f884
Add missing include in utils header
nives-vukovic Jul 12, 2023
5d0e778
Merge branch 'cg_base_dino' into cg_coalesced_group_tests
nives-vukovic Jul 12, 2023
19b9936
Merge branch 'develop' into cg_coalesced_group_tests
rakesroy Jul 14, 2023
607cb25
Update config_amd_linux_common.json
rakesroy Jul 14, 2023
1f0dfc4
Update config_amd_windows_common.json
rakesroy Jul 14, 2023
7473be7
Merge branch 'develop' into cg_coalesced_group_tests
mangupta Jul 18, 2023
86e8cb1
Update CMakeLists.txt
mangupta Jul 18, 2023
efc696d
Merge remote-tracking branch 'origin/develop' into cg_coalesced_group…
nives-vukovic Nov 17, 2023
466c789
Merge remote-tracking branch 'origin/develop' into cg_coalesced_group…
nives-vukovic Dec 12, 2023
941bf5e
Merge remote-tracking branch 'origin/develop' into cg_coalesced_group…
nives-vukovic Dec 29, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions catch/hipTestMain/config/config_amd_linux
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,37 @@
"Unit_hipEventIpc",
"=== SWDEV-427101:Below test fails randomly in PSDB ===",
"Unit_deviceAllocation_InOneThread_AccessInAllThreads",
"=== Below tests fail in external CI for PR https://github.com/ROCm-Developer-Tools/hip-tests/pull/154 ===",
"Unit_Coalesced_Group_Getters_Positive_Basic",
"Unit_Coalesced_Group_Getters_Via_Base_Type_Positive_Basic",
"Unit_Coalesced_Group_Getters_Via_Non_Member_Functions_Positive_Basic",
"Unit_Coalesced_Group_Shfl_Up_Positive_Basic - int",
"Unit_Coalesced_Group_Shfl_Up_Positive_Basic - unsigned int",
"Unit_Coalesced_Group_Shfl_Up_Positive_Basic - long",
"Unit_Coalesced_Group_Shfl_Up_Positive_Basic - unsigned long",
"Unit_Coalesced_Group_Shfl_Up_Positive_Basic - long long",
"Unit_Coalesced_Group_Shfl_Up_Positive_Basic - unsigned long long",
"Unit_Coalesced_Group_Shfl_Up_Positive_Basic - float",
"Unit_Coalesced_Group_Shfl_Up_Positive_Basic - double",
"Unit_Coalesced_Group_Shfl_Down_Positive_Basic - int",
"Unit_Coalesced_Group_Shfl_Down_Positive_Basic - unsigned int",
"Unit_Coalesced_Group_Shfl_Down_Positive_Basic - long",
"Unit_Coalesced_Group_Shfl_Down_Positive_Basic - unsigned long",
"Unit_Coalesced_Group_Shfl_Down_Positive_Basic - long long",
"Unit_Coalesced_Group_Shfl_Down_Positive_Basic - unsigned long long",
"Unit_Coalesced_Group_Shfl_Down_Positive_Basic - float",
"Unit_Coalesced_Group_Shfl_Down_Positive_Basic - double",
"Unit_Coalesced_Group_Shfl_Positive_Basic - int",
"Unit_Coalesced_Group_Shfl_Positive_Basic - unsigned int",
"Unit_Coalesced_Group_Shfl_Positive_Basic - long",
"Unit_Coalesced_Group_Shfl_Positive_Basic - unsigned long",
"Unit_Coalesced_Group_Shfl_Positive_Basic - long long",
"Unit_Coalesced_Group_Shfl_Positive_Basic - unsigned long long",
"Unit_Coalesced_Group_Shfl_Positive_Basic - float",
"Unit_Coalesced_Group_Shfl_Positive_Basic - double",
"Unit_Coalesced_Group_Sync_Positive_Basic - uint8_t",
"Unit_Coalesced_Group_Sync_Positive_Basic - uint16_t",
"Unit_Coalesced_Group_Sync_Positive_Basic - uint32_t",
"=== Patch which removes the typetraits implementation from std namespace in hiprtc is reverted ===",
"Unit_hiprtc_stdheaders",
"Unit_hipMemAddressFree_negative",
Expand Down
9 changes: 9 additions & 0 deletions catch/hipTestMain/config/config_amd_windows
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,15 @@
"Unit_hipFreeAsync_negative",
"Unit_hipLaunchHostFunc_multistreams",
"Unit_hipGraphMem_Alloc_Free_NodeGetParams_Negative",
"=== Below tests fail in external CI for PR https://github.com/ROCm-Developer-Tools/hip-tests/pull/154 ===",
"Unit_Coalesced_Group_Shfl_Positive_Basic - int",
"Unit_Coalesced_Group_Shfl_Positive_Basic - unsigned int",
"Unit_Coalesced_Group_Shfl_Positive_Basic - long",
"Unit_Coalesced_Group_Shfl_Positive_Basic - unsigned long",
"Unit_Coalesced_Group_Shfl_Positive_Basic - long long",
"Unit_Coalesced_Group_Shfl_Positive_Basic - unsigned long long",
"Unit_Coalesced_Group_Shfl_Positive_Basic - float",
"Unit_Coalesced_Group_Shfl_Positive_Basic - double",
"=== SWDEV-431191:Below tests failed in stress test on 03/11/23 ===",
"Unit_hipHostMalloc_AllocateMoreThanAvailGPUMemory",
"Unit_hipHostMalloc_AllocateUseMoreThanAvailGPUMemory",
Expand Down
2 changes: 2 additions & 0 deletions catch/hipTestMain/main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ int main(int argc, char** argv) {
| Opt(cmd_options.progress)
["-P"]["--progress"]
("Show progress bar when running performance tests")
| Opt(cmd_options.cg_iterations, "cg_iterations")
["-E"]["--cg-iterations"]
| Opt(cmd_options.cg_extended_run, "cg_extened_run")
["-E"]["--cg-extended-run"]
("Number of iterations used for cooperative groups sync tests (default: 5)")
Expand Down
3 changes: 2 additions & 1 deletion catch/include/cmd_options.hh
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ THE SOFTWARE.
struct CmdOptions {
int iterations = 10;
int warmups = 100;
int cg_iterations = 5;
int cg_extended_run = 5;
bool no_display = false;
bool progress = false;
};

extern CmdOptions cmd_options;
extern CmdOptions cmd_options;
5 changes: 3 additions & 2 deletions catch/unit/cooperativeGrps/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ set(TEST_SRC
hipLaunchCooperativeKernel_old.cc
hipLaunchCooperativeKernelMultiDevice_old.cc
grid_group.cc
coalesced_groups_shfl_down.cc
coalesced_groups_shfl_up.cc
coalesced_group.cc
coalesced_groups_shfl_down_old.cc
coalesced_groups_shfl_up_old.cc
coalesced_tiled_groups_metagrp.cc
)
if(HIP_PLATFORM STREQUAL "nvidia")
Expand Down
Loading