EXSWHTEC-83 - Implement new and reimplement existing tests for hipMemAdvise #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
music-dino
commented
Dec 7, 2022
music-dino
commented
- Negative parameter tests
- Validate that setting and resetting of flags works as expected
- Validate that setting one flag does not lead to the resetting of another
- Validate round down for base address and roundup for base address + count behavior
- Validate that memory can still be read and write after applying each advice
- Validate that prefetching after setting flags does not interfere with them.
Change-Id: I66f0c09e9c7405ec7430b1883e0e89542fdb87a0
Change-Id: I212b82b1b3a78a368b85ea64e338371a34b405f9
Change-Id: Ib455f72b5be77e1a81137d15c07ea41161b16a3e
Change-Id: Ief96e274f4143e80ceb3e40f04d38ae217777583
Change-Id: I9c03cde09b42c8e3726153c2a177359efc8d6d29
…Advise - Basic positive tests - Negative parameter tests
…hipMemAdvise_tests
chrispaquot
approved these changes
Jan 5, 2023
|
@music-dino : This PR has a few merge conflicts after merging some of the previous PRs. Could you please rebase this change? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.