Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXSWHTEC-75 - Implement tests for hipMemcpyAsync and derivatives #18

Merged
merged 15 commits into from
Jul 11, 2023
Merged

EXSWHTEC-75 - Implement tests for hipMemcpyAsync and derivatives #18

merged 15 commits into from
Jul 11, 2023

Conversation

music-dino
Copy link
Contributor

Implement positive and negative unit tests for the following APIs:

hipMemcpyAsync
hipMemcpyDtoHAsync
hipMemcpyHtoDAsync
hipMemcpyDtoDAsync.

gargrahul and others added 7 commits October 26, 2022 03:59
@gargrahul
SWDEV-355313 - Move catch tests and samples
cea96af 
Change-Id: I66f0c09e9c7405ec7430b1883e0e89542fdb87a0
@gargrahul
SWDEV-355313 - Add README
909e7e4 
Change-Id: I212b82b1b3a78a368b85ea64e338371a34b405f9
@gargrahul
SWDEV-355313 - Update amd-staging branch
094b9af 
Change-Id: Ib455f72b5be77e1a81137d15c07ea41161b16a3e
@gargrahul
SWDEV-355313 - Update README
9daa6d0 
Change-Id: Ief96e274f4143e80ceb3e40f04d38ae217777583
@gargrahul
SWDEV-355313 - Update latest code
c49043e 
Change-Id: I9c03cde09b42c8e3726153c2a177359efc8d6d29
@music-dino
Create common code for 1D memcpy operations
b0848db
@music-dino
EXSWHTEC-75 - Implement tests for hipMemcpyAsync and derivatives
eca94ae 
- Basic positive tests
- Negative parameter tests
@milos-mozetic milos-mozetic mentioned this pull request Dec 28, 2022
Open
@mangupta
Copy link
Contributor

mangupta commented Feb 1, 2023

@milos-mozetic / @music-dino : Can someone look into this PR. The previous resolution of the merge conflict 1ef552a looks incorrect. There are some remnants of the merge conflict that can be seen in hipMemcpyAsync.cc.

@milos-mozetic
Copy link
Contributor

@milos-mozetic / @music-dino : Can someone look into this PR. The previous resolution of the merge conflict 1ef552a looks incorrect. There are some remnants of the merge conflict that can be seen in hipMemcpyAsync.cc.

@mangupta: Sorry for the inconvenience, now the conflict is resolved appropriately within commit dc236b8. @music-dino: can you please double-check that the content of hipMemcpyAsync.cc is as expected from your side?

@chrispaquot
Copy link
Contributor

@milos-mozetic / @music-dino : Can someone look into this PR. The previous resolution of the merge conflict 1ef552a looks incorrect. There are some remnants of the merge conflict that can be seen in hipMemcpyAsync.cc.

@mangupta: Sorry for the inconvenience, now the conflict is resolved appropriately within commit dc236b8. @music-dino: can you please double-check that the content of hipMemcpyAsync.cc is as expected from your side?

Any update?

@music-dino
Copy link
Contributor Author

@milos-mozetic / @music-dino : Can someone look into this PR. The previous resolution of the merge conflict 1ef552a looks incorrect. There are some remnants of the merge conflict that can be seen in hipMemcpyAsync.cc.

@mangupta: Sorry for the inconvenience, now the conflict is resolved appropriately within commit dc236b8. @music-dino: can you please double-check that the content of hipMemcpyAsync.cc is as expected from your side?

Any update?

The contents seem to be correct. Please proceed with the merge.

@rorake
Copy link
Contributor

rorake commented Jun 21, 2023

@music-dino
Will you please resolve the merge conflicts for this PR?

@music-dino
Copy link
Contributor Author

@music-dino Will you please resolve the merge conflicts for this PR?

Merge conflicts have been resolved, please proceed.

@mangupta mangupta merged commit 3f9c1dd into ROCm:develop Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispaquot chrispaquot chrispaquot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@music-dino @mangupta @milos-mozetic @chrispaquot @rorake @gargrahul