EXSWHTEC-76 - Implement additional tests for Malloc/Free API #49
Conversation
nives-vukovic
commented
Dec 9, 2022
nives-vukovic
commented
- Implement positive and negative tests for hipMallocMipmappedArray based on existing hipMalloc3DArray tests
- Implement positive and negative tests for hipFreeMipmappedArray based on existing hipFreeArray tests
- Memory leak fix in Unit_hipMalloc3D_Basic
Change-Id: I66f0c09e9c7405ec7430b1883e0e89542fdb87a0
Change-Id: I212b82b1b3a78a368b85ea64e338371a34b405f9
Change-Id: Ib455f72b5be77e1a81137d15c07ea41161b16a3e
Change-Id: Ief96e274f4143e80ceb3e40f04d38ae217777583
Change-Id: I9c03cde09b42c8e3726153c2a177359efc8d6d29
… arrays - Add resource guards for 2D and 3D allocations - Add resource guards for arrays - Add utils for hadling pitched memory - Add hip_array_common.hh to gather type, size and format mapping
- Implement positive and negative tests for hipMallocMipmappedArray based on existing hipMalloc3DArray tests - Implement positive and negative tests for hipFreeMipmappedArray based on existing hipFreeArray tests - Memory leak fix in Unit_hipMalloc3D_Basic
| */ | ||
|
|
||
| TEMPLATE_TEST_CASE("Unit_hipFreeMipmappedArrayImplicitSyncArray", "", char, float) { | ||
| #ifdef _WIN32 |
There was a problem hiding this comment.
@mangupta @chrispaquot This has been added in line with all other tests that use API that is only functional on Windows OS. This is the case for Mipmapped Array API.
There was a problem hiding this comment.
same as other comment: use json file instead.
There was a problem hiding this comment.
@chrispaquot @mangupta On out system, Mipmapped array APIs only build on Windows, for that reason the tests have been disabled using _WIN32
There was a problem hiding this comment.
I don't understand, the APIs are OS agnostic so should be fine on either ones.
There was a problem hiding this comment.
@chrispaquot Same as with texture management containing Mipmapped APIs, I can remove the win32 defines, and wait for the CL report to check if everything works properly on Linux on your setup. Would that be a good solution from your side?
There was a problem hiding this comment.
@mangupta win32 defines have been removed, please run the CI to check if everything is working correctly regarding linux/windows test build and execution, and report if there are any bugs because we could not run these tests on our systems.
…ipmapped texture size APIs
|
PR has been merged into develop branch via commit 10594ec. |
Change-Id: I9e2fd348e8c1d2bf63f82b90898863006ba90b62
