Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXSWHTEC-103 - Implement tests for hipDrvMemcpy3D APIs #56

Merged
merged 24 commits into from
Jun 28, 2023

Conversation

mirza-halilcevic
Copy link
Contributor

  • Implement basic behavior checks in all copy directions
  • Implement synchronization behavior checks for expected behavior based on cuda docs
  • Implement positive tests for zero sized width and/or height copies, where no copy is expected to happen
  • Implement negative parameter tests
  • Implement all of the above for hipDrvMemcpy3D and hipDrvMemcpy3DAsync.

Depends-on: #55

gargrahul and others added 10 commits October 26, 2022 03:59
Change-Id: I66f0c09e9c7405ec7430b1883e0e89542fdb87a0
Change-Id: I212b82b1b3a78a368b85ea64e338371a34b405f9
Change-Id: Ib455f72b5be77e1a81137d15c07ea41161b16a3e
Change-Id: Ief96e274f4143e80ceb3e40f04d38ae217777583
Change-Id: I9c03cde09b42c8e3726153c2a177359efc8d6d29
… arrays

- Add resource guards for 2D and 3D allocations
- Add resource guards for arrays
- Add utils for hadling pitched memory
- Add hip_array_common.hh to gather type, size and format mapping
- Implement basic behavior checks in all copy directions
- Implement synchronization behavior checks for expected behavior based on cuda docs
- Implement positive tests for zero sized width and/or height copies, where no copy is expected to happen
- Implement negative parameter tests
- Implement all of the above for hipMemcpy3D and hipMemcpy3DAsync.
- Implement basic behavior checks in all copy directions
- Implement synchronization behavior checks for expected behavior based on cuda docs
- Implement positive tests for zero sized width and/or height copies, where no copy is expected to happen
- Implement negative parameter tests
- Implement all of the above for hipDrvMemcpy3D and hipDrvMemcpy3DAsync.
@rorake
Copy link
Contributor

rorake commented Jun 21, 2023

@mirza-halilcevic
Will you please resolve the merge conflicts for this PR?

@mangupta mangupta merged commit c695f1b into ROCm:develop Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants