Skip to content

Commit

Permalink
Update reverted patches (see 964a046 ...changes from several Sema-rel…
Browse files Browse the repository at this point in the history
…ate...

Change-Id: Ib11b6fd49516f00cd0fedd66f9471ef706b07e68
  • Loading branch information
macurtis-amd committed Oct 22, 2024
1 parent 964a046 commit e51df59
Showing 1 changed file with 0 additions and 27 deletions.
27 changes: 0 additions & 27 deletions revert_patches.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,33 +3,6 @@ revert: breaks MIOpen composableKernel build
https://ontrack-internal.amd.com/browse/SWDEV-436625

---
Revert: 8009bbe
Commit title:
Revert "Reapply "[Clang][Sema] Diagnose class member access expressions
naming non-existent members of the current instantiation prior to
instantiation in the absence of dependent base classes (#84050)"
(#90152)"

Reason for revert:
- Breaks composable kernels:

[2024-05-01T03:06:52.796Z] /jenkins/workspace/compiler-psdb-amd-staging/Libs/composable_kernel/include/ck/tensor_operation/gpu/block/blockwise_gemm_xdlops.hpp:799:32: error: no member named 'a_origin' in 'BlockwiseGemmXdlops_v2<BlockSize, FloatAB, FloatAcc, ATileDesc, BTileDesc, AMmaTileDesc, BMmaTileDesc, MPerBlock, NPerBlock, KPerBlock, MPerXDL, NPerXDL, MRepeat, NRepeat, KPack, TransposeC, AMmaKStride, BMmaKStride>'
[2024-05-01T03:06:52.796Z] 799 | : a_thread_copy_(other.a_origin), b_thread_copy_(other.b_origin)
[2024-05-01T03:06:52.796Z] | ~~~~~ ^
[2024-05-01T03:06:52.796Z] /jenkins/workspace/compiler-psdb-amd-staging/Libs/composable_kernel/include/ck/tensor_operation/gpu/block/blockwise_gemm_xdlops.hpp:799:64: error: no member named 'b_origin' in 'BlockwiseGemmXdlops_v2<BlockSize, FloatAB, FloatAcc, ATileDesc, BTileDesc, AMmaTileDesc, BMmaTileDesc, MPerBlock, NPerBlock, KPerBlock, MPerXDL, NPerXDL, MRepeat, NRepeat, KPack, TransposeC, AMmaKStride, BMmaKStride>'
[2024-05-01T03:06:52.796Z] 799 | : a_thread_copy_(other.a_origin), b_thread_copy_(other.b_origin)

- Breaks rocthrust:

[2024-05-01T03:18:40.779Z] /jenkins/workspace/compiler-psdb-amd-staging_2/Libs/rocThrust/thrust/../thrust/optional.h:2756:11: error: no member named 'construct' in 'optional<type-parameter-0-0 &>'
[2024-05-01T03:18:40.779Z] 2756 | this->construct(std::forward<Args>(args)...);

fd87d765c045 [Clang][Sema] Don't build CXXDependentScopeMemberExprs for potent
acf5ad2a4ed9 [Clang][Sema] Diagnose current instantiation used as an incomplete

Contacts:
Sam, Konstantin
---
Revert: 41f9c78
Commit title:
Revert "[OpenACC] Fix test failure from fa67986d"
Expand Down

0 comments on commit e51df59

Please sign in to comment.