[Flang][OpenMP] Add host_eval clause lowering support #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatrak
requested review from
ergawy,
jsjodin,
agozillon,
DominikAdamski,
TIFitis,
kparzysz and
bhandarkar-pranav
This was referenced Oct 10, 2024
skatrak
force-pushed
the
users/skatrak/target-passthrough-03-mlir-llvm
branch
from
e2ee789 to
a9a83c9
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-04-flang
branch
from
03cc419 to
144635d
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-03-mlir-llvm
branch
from
a9a83c9 to
332c9c5
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-04-flang
branch
from
144635d to
f1120d0
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-03-mlir-llvm
branch
from
332c9c5 to
0443d95
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-04-flang
branch
2 times, most recently
from
a18fdc4 to
b739c9c
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-03-mlir-llvm
branch
from
36f00b9 to
0e07eda
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-04-flang
branch
from
b739c9c to
b669de6
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-03-mlir-llvm
branch
from
0e07eda to
a3727a0
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-04-flang
branch
from
b669de6 to
bc7a8e2
Compare
|
Ping! Can someone take a look at this and let me know if we're ok with making the transition to the community-approved approach? This PR stack is currently in the way of upstreaming target SPMD support. |
skatrak
force-pushed
the
users/skatrak/target-passthrough-03-mlir-llvm
branch
from
a3727a0 to
dec7a5e
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-04-flang
branch
from
bc7a8e2 to
fab6db4
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-04-flang
branch
from
fab6db4 to
e29a641
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-03-mlir-llvm
branch
from
dec7a5e to
6e921c3
Compare
Base automatically changed from
users/skatrak/target-passthrough-03-mlir-llvm
to
amd-trunk-dev
November 7, 2024 10:53
This patch updates Flang lowering to use the `host_eval` clause in `omp.target` operations to pass host information into the applicable clauses inside of the target region, instead of the previous approach where these clauses were attached to the `omp.target` operation itself.
skatrak
force-pushed
the
users/skatrak/target-passthrough-04-flang
branch
from
e29a641 to
5f080c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates Flang lowering and the
do concurrentconversion pass to use thehost_evalclause inomp.targetoperations to pass host information into the applicable clauses inside of the target region, instead of the previous approach where these clauses were attached to theomp.targetoperation itself.The map info finalization pass is updated, because it previously didn't support the case where there are entry block arguments defined by other clauses placed before the map-like clauses being introduced by the pass.
The detection of when to evaluate outside of the target region is also improved for the target SPMD case in Flang lowering.