[MLIR][OpenMP] Fix handling of constant num_teams/threads #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR stack transitioning to the `host_eval` representation for introduced an issue causing the `num_teams`, `thread_limit` and `num_threads` clauses to not properly initialize kernel attributes during target device compilation when these are constant. This patch fixes that issue by using host-evaluated values instead of their corresponding block argument when extracting these constant values.
skatrak
requested review from
ergawy,
jsjodin,
agozillon,
DominikAdamski,
TIFitis,
kparzysz and
bhandarkar-pranav
That was quick, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR stack transitioning to the
host_evalrepresentation introduced an issue causing thenum_teams,thread_limitandnum_threadsclauses to not properly initialize kernel attributes during target device compilation when these are constant.This patch fixes that issue by using host-evaluated values instead of their corresponding block arguments when extracting these constant values.