Generate teams reductions inside the distribute if the reduction is done inside the distribute op. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction computation is contained within the distribute op.
jsjodin
requested review from
agozillon,
DominikAdamski,
dpalermo,
TIFitis and
skatrak
|
I thought a bit more and the check needs to be enhanced to ensure that a single distribute operation is enclosing the reduction to allow the code generation of the reduction inside a distribute op. Otherwise it could potentially generate the reduction code twice one for each distribute op. |
dpalermo
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the generation of teams reductions to the distribute op in the case for 'teams distribute parallel do' and 'teams distribute' to make the reductions more efficient. The deviceRTL function uses all the threads in the final teams to do the second level reductions.