Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP] [Flang] [MLIR] Allow dist_schedule(static) to be default behavior in OMP DISTRIBUTE directive #220

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[OpenMP] [Flang] [MLIR] Allow dist_schedule(static) to be default behavior in OMP DISTRIBUTE directive #220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4118b68
[OpenMP] [Flang] [MLIR] Allow dist_schedule(static) to be default beh…
raghavendhra Dec 3, 2024
9626d42
Address review comment.
raghavendhra Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ static LogicalResult checkImplementationStatus(Operation &op) {
result = todo("device");
};
auto checkDistSchedule = [&todo](auto op, LogicalResult &result) {
if (op.getDistScheduleStatic() || op.getDistScheduleChunkSize())
result = todo("dist_schedule");
if (op.getDistScheduleChunkSize())
result = todo("dist_schedule chunk_size");
raghavendhra marked this conversation as resolved.
Show resolved Hide resolved
};
auto checkHasDeviceAddr = [&todo](auto op, LogicalResult &result) {
if (!op.getHasDeviceAddrVars().empty())
Expand Down
2 changes: 1 addition & 1 deletion mlir/test/Target/LLVMIR/openmp-todo.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ llvm.func @distribute_allocate(%lb : i32, %ub : i32, %step : i32, %x : !llvm.ptr
// -----

llvm.func @distribute_dist_schedule(%lb : i32, %ub : i32, %step : i32, %x : i32) {
// expected-error@below {{not yet implemented: Unhandled clause dist_schedule in omp.distribute operation}}
// expected-error@below {{not yet implemented: Unhandled clause dist_schedule chunk_size in omp.distribute operation}}
raghavendhra marked this conversation as resolved.
Show resolved Hide resolved
// expected-error@below {{LLVM Translation failed for operation: omp.distribute}}
omp.distribute dist_schedule_static dist_schedule_chunk_size(%x : i32) {
omp.loop_nest (%iv) : i32 = (%lb) to (%ub) step (%step) {
Expand Down