Skip to content

Commit

Permalink
Remove MI308X identification using num CUs, and format Python using b…
Browse files Browse the repository at this point in the history
…lack.

Signed-off-by: xuchen-amd <xuchen@amd.com>
  • Loading branch information
xuchen-amd committed Sep 17, 2024
1 parent 915f859 commit 90a575a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
6 changes: 3 additions & 3 deletions src/omniperf_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@
}

MI300_CHIP_IDS = {
"29856" : "MI300A_A1",
"29857" : "MI300X_A1",
"29858" : "MI308X",
"29856": "MI300A_A1",
"29857": "MI300X_A1",
"29858": "MI308X",
}


Expand Down
5 changes: 1 addition & 4 deletions src/omniperf_soc/soc_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def populate_mspec(self):
key = search(r"^\s*Chip ID:\s+ ([a-zA-Z0-9]+)\s*", linetext)
if key != None:
self._mspec.chip_id = key
continue
continue

key = search(r"^\s*Max Waves Per CU:\s+ ([a-zA-Z0-9]+)\s*", linetext)
if key != None:
Expand Down Expand Up @@ -200,9 +200,6 @@ def populate_mspec(self):
or "MI300X" in self.check_arch_override()
):
self._mspec.gpu_model = "MI300X_A1"
# We need to distinguish MI308X by peeking reported num CUs
elif self._mspec.cu_per_gpu == "80" or "MI308X" in self.check_arch_override():
self._mspec.gpu_model = "MI308X"
# Use Chip ID to distinguish the gpu model by using built-in dictionary
elif self._mspec.chip_id in MI300_CHIP_IDS:
self._mspec.chip_id = MI300_CHIP_IDS[self._mspec.chip_id]
Expand Down
4 changes: 2 additions & 2 deletions src/utils/specs.py
Original file line number Diff line number Diff line change
Expand Up @@ -406,10 +406,10 @@ class MachineSpecs:
chip_id: str = field(
default=None,
metadata={
"doc":"<>",
"doc": "<>",
"name": "Chip ID",
},
)
)
max_waves_per_cu: str = field(
default=None,
metadata={
Expand Down

0 comments on commit 90a575a

Please sign in to comment.