Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of calls to rocprof #384

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Reduce number of calls to rocprof #384

merged 8 commits into from
Jul 18, 2024

Commits on Jul 17, 2024

  1. Improve perfmon coalescing 

    Signed-off-by: benrichard-amd <ben.richard@amd.com>
    @benrichard-amd
    benrichard-amd committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    4c55b67 View commit details
    Browse the repository at this point in the history

  2. Interleve TCC channel counters 

    Signed-off-by: benrichard-amd <ben.richard@amd.com>
    @benrichard-amd
    benrichard-amd committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    68e8a7a View commit details
    Browse the repository at this point in the history

  3. Remove duplicate normal counters 

    Interleve TCC channel counters in putput file  e.g.  TCC_HIT[0] TCC_ATOMIC[0] ... TCC_HIT[1] TCC_ATOMIC[1]

Signed-off-by: benrichard-amd <ben.richard@amd.com>
    @benrichard-amd
    benrichard-amd committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6df5dee View commit details
    Browse the repository at this point in the history

  4. Save accumulate counters to SQ_ files 

    Omniperf analyze expects the accumulate files to be in SQ_*.csv files.

Since these files also contain PMC counters (we are trying to
fit as many counters into each file as possible to minimize runs),
we need to include these SQ_*.csv files in pmc_perf.csv.

Signed-off-by: benrichard-amd <ben.richard@amd.com>
    @benrichard-amd
    benrichard-amd committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    7e5a08d View commit details
    Browse the repository at this point in the history

  5. Update to work with rocprof v1 

    Signed-off-by: benrichard-amd <ben.richard@amd.com>
    @benrichard-amd
    benrichard-amd committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    77ced24 View commit details
    Browse the repository at this point in the history

  6. Remove unused method 

    Signed-off-by: benrichard-amd <ben.richard@amd.com>
    @benrichard-amd
    benrichard-amd committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    473f252 View commit details
    Browse the repository at this point in the history

  7. Set correct number of TCC channels for gfx942 

    Ran into rocprof error:
ROCProfiler: fatal error: input metric'TCC_EA0_RDREQ[16]' not supported on this hardware: gfx942

gfx942 has 16 channels, not 32.

Signed-off-by: benrichard-amd <ben.richard@amd.com>
    @benrichard-amd
    benrichard-amd committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    eb83d74 View commit details
    Browse the repository at this point in the history

  8. Fix code formatting 

    Signed-off-by: benrichard-amd <ben.richard@amd.com>
    @benrichard-amd
    benrichard-amd committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5eaed48 View commit details
    Browse the repository at this point in the history