Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rocprofv1 for additional socs #391

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

xuchen-amd
Copy link
Contributor

@xuchen-amd xuchen-amd commented Aug 1, 2024

Enable rocprofv1 for soc_gfx940.py, soc_gfx941.py, soc_gfx942.py.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

@xuchen-amd xuchen-amd requested review from a team, koomie and coleramos425 as code owners August 1, 2024 20:16
@xuchen-amd xuchen-amd changed the title Enable rocprofv2 for additional socs Enable rocprofv1 for additional socs Aug 1, 2024
@coleramos425
Copy link
Collaborator

@xuchen-amd can you modify the PR to merge into dev branch instead of main?

@coleramos425 coleramos425 linked an issue Aug 1, 2024 that may be closed by this pull request
@xuchen-amd xuchen-amd closed this Aug 1, 2024
@xuchen-amd xuchen-amd deleted the xuchen-dev branch August 1, 2024 20:59
@xuchen-amd xuchen-amd restored the xuchen-dev branch August 1, 2024 20:59
@xuchen-amd xuchen-amd reopened this Aug 2, 2024
@xuchen-amd
Copy link
Contributor Author

reopening PR.

@coleramos425
Copy link
Collaborator

@xuchen-amd looks like the PR is reporting 316 files changed. This is likely because your branch is out of date with the base. Could you update your branch with a rebase?

@xuchen-amd
Copy link
Contributor Author

@xuchen-amd looks like the PR is reporting 316 files changed. This is likely because your branch is out of date with the base. Could you update your branch with a rebase?

I did a local rebase to origin/main, do I need to push again? Or should I use "update branch with rebase"? Thanks!

@coleramos425
Copy link
Collaborator

@xuchen-amd I've sent you a short meeting request via Outlook. A quick discussion should be the fastest solution.

@xuchen-amd xuchen-amd changed the base branch from main to dev August 6, 2024 20:34
Signed-off-by: xuchen-amd <xuchen@amd.com>
Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

Signed-off-by: xuchen-amd <xuchen@amd.com>
@coleramos425 coleramos425 merged commit d0a80fe into ROCm:dev Aug 7, 2024
10 checks passed
dgaliffiAMD pushed a commit that referenced this pull request Aug 9, 2024
* Enable rocprofv1 for gfx940/941/942.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Enable rocprofv1 for gfx940/941/942.

Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd added a commit to xuchen-amd/omniperf that referenced this pull request Aug 15, 2024
* Enable rocprofv1 for gfx940/941/942.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Enable rocprofv1 for gfx940/941/942.

Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
lajagapp pushed a commit to lajagapp/omniperf that referenced this pull request Aug 16, 2024
* Enable rocprofv1 for gfx940/941/942.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Enable rocprofv1 for gfx940/941/942.

Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
lajagapp pushed a commit to lajagapp/omniperf that referenced this pull request Aug 16, 2024
* Enable rocprofv1 for gfx940/941/942.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Enable rocprofv1 for gfx940/941/942.

Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
coleramos425 pushed a commit that referenced this pull request Aug 16, 2024
* Enable rocprofv1 for gfx940/941/942.



* Enable rocprofv1 for gfx940/941/942.

Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924



---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd added a commit to xuchen-amd/omniperf that referenced this pull request Sep 10, 2024
* Enable rocprofv1 for gfx940/941/942.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Enable rocprofv1 for gfx940/941/942.

Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd added a commit to xuchen-amd/omniperf that referenced this pull request Oct 16, 2024
* Enable rocprofv1 for gfx940/941/942.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Enable rocprofv1 for gfx940/941/942.

Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd added a commit to xuchen-amd/omniperf that referenced this pull request Oct 17, 2024
* Enable rocprofv1 for gfx940/941/942.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Enable rocprofv1 for gfx940/941/942.

Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd added a commit to xuchen-amd/omniperf that referenced this pull request Oct 19, 2024
* Enable rocprofv1 for gfx940/941/942.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Enable rocprofv1 for gfx940/941/942.

Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable rocprof (v1) support for MI300 profiling
2 participants