Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs housekeeping post-6.2.0 #394

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Docs housekeeping post-6.2.0 #394

merged 3 commits into from
Aug 2, 2024

Conversation

peterjunpark
Copy link
Contributor

This PR

  • Removes leftover css to align link colors with other ROCm component docs.
  • Fixes a dead link.
  • Adds a note in the archived docs pointing to the latest version.
    image

@peterjunpark
remove leftover css
11e3e36 
Signed-off-by: Peter Jun Park <peter.park@amd.com>
@peterjunpark
fix link to panel_config_template.yaml
3b2ecee 
Signed-off-by: Peter Jun Park <peter.park@amd.com>
@peterjunpark
add note in archived docs pointing to latest
151e88c 
Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition
@peterjunpark peterjunpark added the documentation Improvements or additions to documentation label Aug 2, 2024
@peterjunpark peterjunpark requested a review from a team as a code owner August 2, 2024 20:48
peterjunpark
peterjunpark commented Aug 2, 2024
View reviewed changes
docs/how-to/analyze/cli.rst
`config_template <https://github.com/ROCm/omniperf/blob/main/src/omniperf_analyze/configs/panel_config_template.yaml>`_.
`config_template <https://github.com/ROCm/omniperf/blob/main/src/omniperf_soc/analysis_configs/panel_config_template.yaml>`_.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinkkk this is the right link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's right

skyreflectedinmirrors
skyreflectedinmirrors approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@skyreflectedinmirrors skyreflectedinmirrors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterjunpark peterjunpark merged commit e4306f6 into ROCm:dev Aug 2, 2024
10 checks passed
peterjunpark added a commit to peterjunpark/omniperf that referenced this pull request Aug 2, 2024
@peterjunpark
Docs housekeeping post-6.2.0 (ROCm#394)
0c9fa7f 
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
peterjunpark added a commit that referenced this pull request Aug 2, 2024
@peterjunpark
Merge pull request #395 from peterjunpark/docs/6.2.0
f04d86b 
Docs housekeeping post-6.2.0 (#394)
dgaliffiAMD pushed a commit that referenced this pull request Aug 9, 2024
@peterjunpark @dgaliffiAMD
Docs housekeeping post-6.2.0 (#394)
e8fc341 
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
peterjunpark added a commit to peterjunpark/omniperf that referenced this pull request Oct 1, 2024
@peterjunpark
Docs housekeeping post-6.2.0 (ROCm#394)
4408fdf 
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
peterjunpark added a commit to peterjunpark/omniperf that referenced this pull request Oct 7, 2024
@peterjunpark
Docs housekeeping post-6.2.0 (ROCm#394)
cb31b68 
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
Signed-off-by: Peter Park <peter.park@amd.com>
xuchen-amd pushed a commit to xuchen-amd/omniperf that referenced this pull request Oct 16, 2024
@peterjunpark @xuchen-amd
Docs housekeeping post-6.2.0 (ROCm#394)
9950ed4 
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd pushed a commit to xuchen-amd/omniperf that referenced this pull request Oct 17, 2024
@peterjunpark @xuchen-amd
Docs housekeeping post-6.2.0 (ROCm#394)
fe56ec7 
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd pushed a commit to xuchen-amd/omniperf that referenced this pull request Oct 19, 2024
@peterjunpark @xuchen-amd
Docs housekeeping post-6.2.0 (ROCm#394)
6a0f464 
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd pushed a commit to xuchen-amd/omniperf that referenced this pull request Oct 19, 2024
@peterjunpark @xuchen-amd
Docs housekeeping post-6.2.0 (ROCm#394)
aaedb66 
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd pushed a commit to xuchen-amd/omniperf that referenced this pull request Oct 19, 2024
@peterjunpark @xuchen-amd
Docs housekeeping post-6.2.0 (ROCm#394)
0249b2f 
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd pushed a commit to xuchen-amd/omniperf that referenced this pull request Oct 19, 2024
@peterjunpark @xuchen-amd
Docs housekeeping post-6.2.0 (ROCm#394)
46365e9 
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyreflectedinmirrors skyreflectedinmirrors skyreflectedinmirrors approved these changes

@coleramos425 coleramos425 coleramos425 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterjunpark @skyreflectedinmirrors @coleramos425