-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocprof-compute branding update #428
Open
xuchen-amd
wants to merge
412
commits into
ROCm:amd-staging
Choose a base branch
from
xuchen-amd:rocprof-compute_branding_update
base: amd-staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
rocprof-compute branding update #428
xuchen-amd
wants to merge
412
commits into
ROCm:amd-staging
from
xuchen-amd:rocprof-compute_branding_update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuchen-amd
requested review from
a team,
koomie and
coleramos425
as code owners
September 24, 2024 15:44
coleramos425
force-pushed
the
amd-staging
branch
from
September 25, 2024 17:24
6265391
to
0d15023
Compare
Subtask
|
coleramos425
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See requested subtask above
3 tasks
dgaliffiAMD
requested changes
Oct 10, 2024
dgaliffiAMD
reviewed
Oct 10, 2024
xuchen-amd
force-pushed
the
rocprof-compute_branding_update
branch
from
October 16, 2024 20:05
48152d6
to
8062ae1
Compare
dgaliffiAMD
reviewed
Oct 16, 2024
xuchen-amd
force-pushed
the
rocprof-compute_branding_update
branch
from
October 17, 2024 00:19
9753c80
to
0e7085c
Compare
dgaliffiAMD
approved these changes
Oct 17, 2024
dgaliffiAMD
reviewed
Oct 17, 2024
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Interleve TCC channel counters in putput file e.g. TCC_HIT[0] TCC_ATOMIC[0] ... TCC_HIT[1] TCC_ATOMIC[1] Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Omniperf analyze expects the accumulate files to be in SQ_*.csv files. Since these files also contain PMC counters (we are trying to fit as many counters into each file as possible to minimize runs), we need to include these SQ_*.csv files in pmc_perf.csv. Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
* pip-compile docs/requirements.txt Signed-off-by: Peter Jun Park <peter.park@amd.com> Add Sphinx docs config Signed-off-by: Peter Jun Park <peter.park@amd.com> Add Sphinx config Signed-off-by: Peter Jun Park <peter.park@amd.com> Update docs build config Signed-off-by: Peter Jun Park <peter.park@amd.com> * style(conf.py): Apply black formatting to docs/conf.py Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * Update docs requirements Signed-off-by: Peter Jun Park <peter.park@amd.com> Update to rocm-docs-core 1.3.0 Signed-off-by: Peter Jun Park <peter.park@amd.com> Update docs requirements Signed-off-by: Peter Jun Park <peter.park@amd.com> pip-compile requirements Signed-off-by: Peter Jun Park <peter.park@amd.com> bump rocm-docs-core to 1.5.0 bump rocm-docs-core to 1.4.1 Signed-off-by: Peter Jun Park <peter.park@amd.com> * Add dependabot.yml and update CODEOWNERS Signed-off-by: Peter Jun Park <peter.park@amd.com> Update toc and conf Signed-off-by: Peter Jun Park <peter.park@amd.com> update dependabot * Port docs to rocm-docs standard Signed-off-by: Peter Jun Park <peter.park@amd.com> Add toc and Diataxis cards Signed-off-by: Peter Jun Park <peter.park@amd.com> Add basic file structure Signed-off-by: Peter Jun Park <peter.park@amd.com> add glossary Signed-off-by: Peter Jun Park <peter.park@amd.com> add includes Signed-off-by: Peter Jun Park <peter.park@amd.com> Add license.rst Signed-off-by: Peter Jun Park <peter.park@amd.com> add compatible hw Signed-off-by: Peter Jun Park <peter.park@amd.com> fix spelling and license Signed-off-by: Peter Jun Park <peter.park@amd.com> clean up index Signed-off-by: Peter Jun Park <peter.park@amd.com> clean up installation guides Signed-off-by: Peter Jun Park <peter.park@amd.com> add basic usage (quickstart) Signed-off-by: Peter Jun Park <peter.park@amd.com> add ref to global options update toc Signed-off-by: Peter Jun Park <peter.park@amd.com> modularize modes and global options Signed-off-by: Peter Jun Park <peter.park@amd.com> add profile mode Signed-off-by: Peter Jun Park <peter.park@amd.com> fixes Signed-off-by: Peter Jun Park <peter.park@amd.com> reorg and clean up Signed-off-by: Peter Jun Park <peter.park@amd.com> add dynamic omniperf version number in installation guide Signed-off-by: Peter Jun Park <peter.park@amd.com> add datatemplate more reorg Signed-off-by: Peter Jun Park <peter.park@amd.com> clean up Signed-off-by: Peter Jun Park <peter.park@amd.com> reorg images move profile mode reorg reorg reorg more fix formatting fix headings ref anchor mi2xx note add extlinks add extlinks Signed-off-by: Peter Jun Park <peter.park@amd.com> black format fix formatting, anchors Signed-off-by: Peter Jun Park <peter.park@amd.com> reorg fix words and formatting Signed-off-by: Peter Jun Park <peter.park@amd.com> formatting Signed-off-by: Peter Jun Park <peter.park@amd.com> same reorg format fix formatting fix toc Signed-off-by: Peter Jun Park <peter.park@amd.com> format * impr internal linking and fix sphinx warnings Signed-off-by: Peter Jun Park <peter.park@amd.com> * add spellcheck/linting from rocm-docs-core Signed-off-by: Peter Jun Park <peter.park@amd.com> fix rst directives satisfy spellcheck fix more spelling rm unused files fix spelling and update wordlist * bump rocm-docs-core to 1.6.0 Signed-off-by: Peter Jun Park <peter.park@amd.com> * add fixes from @skyreflectedinmirrors and @lpaoletti Signed-off-by: Peter Jun Park <peter.park@amd.com> add references to toc Signed-off-by: Peter Jun Park <peter.park@amd.com> add more fixes Signed-off-by: Peter Jun Park <peter.park@amd.com> * add package manager install section Signed-off-by: Peter Jun Park <peter.park@amd.com> * add fixes Signed-off-by: Peter Jun Park <peter.park@amd.com> add metadata and fixes Signed-off-by: Peter Jun Park <peter.park@amd.com> add fixes bump to 1.6.1 more fixes fix fmt in profiling examples Signed-off-by: Peter Jun Park <peter.park@amd.com> add missing mem type table Signed-off-by: Peter Jun Park <peter.park@amd.com> fix formatting fmt * add custom css Signed-off-by: Peter Jun Park <peter.park@amd.com> fix css fs * make images/figs click-to-expand Signed-off-by: Peter Jun Park <peter.park@amd.com> add missed image update fix link * update documentation link in README Signed-off-by: Peter Jun Park <peter.park@amd.com> * formatting fixes Signed-off-by: Peter Jun Park <peter.park@amd.com> more formatting * fix heading Signed-off-by: Peter Jun Park <peter.park@amd.com> * move archived docs Signed-off-by: Peter Jun Park <peter.park@amd.com> * exclude archived docs from docs build Signed-off-by: Peter Jun Park <peter.park@amd.com> * update archived docs workflow Signed-off-by: Peter Jun Park <peter.park@amd.com> move files update archived docs workflow Signed-off-by: Peter Jun Park <peter.park@amd.com> fix version number clean up workflow workflow test workflow test another workflow test * rm docs linting Signed-off-by: Peter Jun Park <peter.park@amd.com> * Apply cmake-format suggested changes Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * Apply cmake-format Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com> --------- Signed-off-by: Peter Jun Park <peter.park@amd.com> Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
…ames omniperf to rocprof-compute in places highly visible to an average external user, i.e., renaming in commands, usage messages, logs, and other command line outputs. Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
If we don't add the suffix omniperf to the install path then the subsequent instruction of module load omniperf will not work Signed-off-by: coleramos425 <colramos@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
After meeting with the DevOps team, I've added the Unreleased keyword to new CHANGELOG section per their request Signed-off-by: coleramos425 <colramos@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
…#420) Signed-off-by: Peter Jun Park <peter.park@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <colramos@amd.com> * Apply linting feedback Signed-off-by: coleramos425 <colramos@amd.com> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <colramos@amd.com> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <colramos@amd.com> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <colramos@amd.com> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <colramos@amd.com> * Synax change for release name in packaging action Signed-off-by: coleramos425 <colramos@amd.com> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <colramos@amd.com> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <colramos@amd.com> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <colramos@amd.com> --------- Signed-off-by: coleramos425 <colramos@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
…#433) Signed-off-by: Carrie Fallows <carrie.fallows@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
…OCm#376) * Fix crash in multi-GPU scenario Exclude -o option when invoking rocprof so that each rocprof process writes to a different .csv file. Concatenate into a single .csv file when finished. Signed-off-by: benrichard-amd <ben.richard@amd.com> * Only combine csv files when using rocprofv2 rocprofv1 does not have separate csv files Signed-off-by: benrichard-amd <ben.richard@amd.com> * Fix indices in combined CSV file Use ignore_index flag to ensure there are no duplicate indices. Signed-off-by: benrichard-amd <ben.richard@amd.com> * Fix Dispatch_ID column and remove unnamed column -Pandas was inserting an unnamed column (index column) -Overwrite the Dispatch_ID column so that every row is unique, starting at 0 -Remove fixup_rocprofv2_dispatch_ids as no longer needed Signed-off-by: benrichard-amd <ben.richard@amd.com> * Fix code formatting Signed-off-by: benrichard-amd <ben.richard@amd.com> * Fix code formatting (for real this time) Signed-off-by: benrichard-amd <ben.richard@amd.com> --------- Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Interleve TCC channel counters in putput file e.g. TCC_HIT[0] TCC_ATOMIC[0] ... TCC_HIT[1] TCC_ATOMIC[1] Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Omniperf analyze expects the accumulate files to be in SQ_*.csv files. Since these files also contain PMC counters (we are trying to fit as many counters into each file as possible to minimize runs), we need to include these SQ_*.csv files in pmc_perf.csv. Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
* pip-compile docs/requirements.txt Signed-off-by: Peter Jun Park <peter.park@amd.com> Add Sphinx docs config Signed-off-by: Peter Jun Park <peter.park@amd.com> Add Sphinx config Signed-off-by: Peter Jun Park <peter.park@amd.com> Update docs build config Signed-off-by: Peter Jun Park <peter.park@amd.com> * style(conf.py): Apply black formatting to docs/conf.py Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * Update docs requirements Signed-off-by: Peter Jun Park <peter.park@amd.com> Update to rocm-docs-core 1.3.0 Signed-off-by: Peter Jun Park <peter.park@amd.com> Update docs requirements Signed-off-by: Peter Jun Park <peter.park@amd.com> pip-compile requirements Signed-off-by: Peter Jun Park <peter.park@amd.com> bump rocm-docs-core to 1.5.0 bump rocm-docs-core to 1.4.1 Signed-off-by: Peter Jun Park <peter.park@amd.com> * Add dependabot.yml and update CODEOWNERS Signed-off-by: Peter Jun Park <peter.park@amd.com> Update toc and conf Signed-off-by: Peter Jun Park <peter.park@amd.com> update dependabot * Port docs to rocm-docs standard Signed-off-by: Peter Jun Park <peter.park@amd.com> Add toc and Diataxis cards Signed-off-by: Peter Jun Park <peter.park@amd.com> Add basic file structure Signed-off-by: Peter Jun Park <peter.park@amd.com> add glossary Signed-off-by: Peter Jun Park <peter.park@amd.com> add includes Signed-off-by: Peter Jun Park <peter.park@amd.com> Add license.rst Signed-off-by: Peter Jun Park <peter.park@amd.com> add compatible hw Signed-off-by: Peter Jun Park <peter.park@amd.com> fix spelling and license Signed-off-by: Peter Jun Park <peter.park@amd.com> clean up index Signed-off-by: Peter Jun Park <peter.park@amd.com> clean up installation guides Signed-off-by: Peter Jun Park <peter.park@amd.com> add basic usage (quickstart) Signed-off-by: Peter Jun Park <peter.park@amd.com> add ref to global options update toc Signed-off-by: Peter Jun Park <peter.park@amd.com> modularize modes and global options Signed-off-by: Peter Jun Park <peter.park@amd.com> add profile mode Signed-off-by: Peter Jun Park <peter.park@amd.com> fixes Signed-off-by: Peter Jun Park <peter.park@amd.com> reorg and clean up Signed-off-by: Peter Jun Park <peter.park@amd.com> add dynamic omniperf version number in installation guide Signed-off-by: Peter Jun Park <peter.park@amd.com> add datatemplate more reorg Signed-off-by: Peter Jun Park <peter.park@amd.com> clean up Signed-off-by: Peter Jun Park <peter.park@amd.com> reorg images move profile mode reorg reorg reorg more fix formatting fix headings ref anchor mi2xx note add extlinks add extlinks Signed-off-by: Peter Jun Park <peter.park@amd.com> black format fix formatting, anchors Signed-off-by: Peter Jun Park <peter.park@amd.com> reorg fix words and formatting Signed-off-by: Peter Jun Park <peter.park@amd.com> formatting Signed-off-by: Peter Jun Park <peter.park@amd.com> same reorg format fix formatting fix toc Signed-off-by: Peter Jun Park <peter.park@amd.com> format * impr internal linking and fix sphinx warnings Signed-off-by: Peter Jun Park <peter.park@amd.com> * add spellcheck/linting from rocm-docs-core Signed-off-by: Peter Jun Park <peter.park@amd.com> fix rst directives satisfy spellcheck fix more spelling rm unused files fix spelling and update wordlist * bump rocm-docs-core to 1.6.0 Signed-off-by: Peter Jun Park <peter.park@amd.com> * add fixes from @skyreflectedinmirrors and @lpaoletti Signed-off-by: Peter Jun Park <peter.park@amd.com> add references to toc Signed-off-by: Peter Jun Park <peter.park@amd.com> add more fixes Signed-off-by: Peter Jun Park <peter.park@amd.com> * add package manager install section Signed-off-by: Peter Jun Park <peter.park@amd.com> * add fixes Signed-off-by: Peter Jun Park <peter.park@amd.com> add metadata and fixes Signed-off-by: Peter Jun Park <peter.park@amd.com> add fixes bump to 1.6.1 more fixes fix fmt in profiling examples Signed-off-by: Peter Jun Park <peter.park@amd.com> add missing mem type table Signed-off-by: Peter Jun Park <peter.park@amd.com> fix formatting fmt * add custom css Signed-off-by: Peter Jun Park <peter.park@amd.com> fix css fs * make images/figs click-to-expand Signed-off-by: Peter Jun Park <peter.park@amd.com> add missed image update fix link * update documentation link in README Signed-off-by: Peter Jun Park <peter.park@amd.com> * formatting fixes Signed-off-by: Peter Jun Park <peter.park@amd.com> more formatting * fix heading Signed-off-by: Peter Jun Park <peter.park@amd.com> * move archived docs Signed-off-by: Peter Jun Park <peter.park@amd.com> * exclude archived docs from docs build Signed-off-by: Peter Jun Park <peter.park@amd.com> * update archived docs workflow Signed-off-by: Peter Jun Park <peter.park@amd.com> move files update archived docs workflow Signed-off-by: Peter Jun Park <peter.park@amd.com> fix version number clean up workflow workflow test workflow test another workflow test * rm docs linting Signed-off-by: Peter Jun Park <peter.park@amd.com> * Apply cmake-format suggested changes Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * Apply cmake-format Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com> --------- Signed-off-by: Peter Jun Park <peter.park@amd.com> Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com> Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.