Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exit gotcha + remove DelayedInit state + rocm-smi + cleanup #110

Merged
merged 2 commits into from
Jul 25, 2022
Merged

exit gotcha + remove DelayedInit state + rocm-smi + cleanup #110

merged 2 commits into from
Jul 25, 2022

Conversation

jrmadsen
Copy link
Collaborator

  • exit gotcha which wraps exit, quick_exit, abort
    • this fixes occasional finalization segfault with timemory data when exit is called in code
  • minor refactor of mpi gotchas
  • removed some redundant code in omnitrace_finalized_hidden
  • exclude instrumenting functions starting with dlopen and dlsym
  • exclude instrumenting exit, quick_exit, and abort functions
  • update timemory submodule with support for new gotcha_invoker with (gotcha_data, , args...)
  • improved rocm-smi error handling

@jrmadsen
exit gotcha + remove DelayedInit state + cleanup
e040de6 
- exit gotcha which wraps exit, quick_exit, abort
- minor refactor of mpi gotchas
- removed some redundant code in omnitrace_finalized_hidden
- exclude instrumenting functions starting with dlopen and dlsym
- exclude instrumenting exit, quick_exit, and abort functions
- update timemory submodule with support for new gotcha_invoker with (gotcha_data, <function pointer>, args...)
@jrmadsen
Improved rocm_smi error handling
4e48581
@jrmadsen jrmadsen added bug fix Fixes a bug timemory Issue affects/involves timemory features/capabilities libomnitrace Involves omnitrace library omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter) rocm-smi ROCm System Management Interface GOTCHA Modifies/adds gotcha wrappers submodule Updates a git submodule labels Jul 25, 2022
@jrmadsen jrmadsen merged commit 99da25e into ROCm:main Jul 25, 2022
@jrmadsen jrmadsen deleted the exit-gotcha branch July 25, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix Fixes a bug GOTCHA Modifies/adds gotcha wrappers libomnitrace Involves omnitrace library omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter) rocm-smi ROCm System Management Interface submodule Updates a git submodule timemory Issue affects/involves timemory features/capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrmadsen