Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable HSA API and activity by default #183

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Disable HSA API and activity by default #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions source/lib/omnitrace/library/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@ configure_settings(bool _init)
"Enable support for Kokkos Tools", false, "kokkos",
"backend");

OMNITRACE_CONFIG_SETTING(bool, "OMNITRACE_USE_MPIP",
"Enable support for MPI functions", true, "mpi", "backend",
"parallelism");

OMNITRACE_CONFIG_SETTING(
bool, "OMNITRACE_USE_RCCLP",
"Enable support for ROCm Communication Collectives Library (RCCL) Performance",
Expand Down Expand Up @@ -504,11 +508,11 @@ configure_settings(bool _init)
0, "sampling", "advanced");

OMNITRACE_CONFIG_SETTING(bool, "OMNITRACE_ROCTRACER_HSA_ACTIVITY",
"Enable HSA activity tracing support", true, "roctracer",
"Enable HSA activity tracing support", false, "roctracer",
"rocm", "advanced");

OMNITRACE_CONFIG_SETTING(bool, "OMNITRACE_ROCTRACER_HSA_API",
"Enable HSA API tracing support", true, "roctracer", "rocm",
"Enable HSA API tracing support", false, "roctracer", "rocm",
"advanced");

OMNITRACE_CONFIG_SETTING(std::string, "OMNITRACE_ROCTRACER_HSA_API_TYPES",
Expand Down Expand Up @@ -772,11 +776,6 @@ configure_settings(bool _init)
OMNITRACE_BASIC_PRINT("config file '%s':\n%s\n", fitr.c_str(),
_iss.str().c_str());
}
if(!_iss.str().empty())
{
OMNITRACE_BASIC_PRINT("config file '%s':\n%s", itr.c_str(),
_iss.str().c_str());
}
}
}

Expand All @@ -793,6 +792,10 @@ configure_settings(bool _init)
_settings_are_configured() = true;
}

#if !defined(OMNITRACE_USE_MPI) && !defined(OMNITRACE_USE_MPI_HEADERS)
set_setting_value("OMNITRACE_USE_MPIP", false);
#endif

_config->get_global_components() =
_config->get<std::string>("OMNITRACE_TIMEMORY_COMPONENTS");

Expand Down Expand Up @@ -1524,8 +1527,8 @@ get_use_pid()
bool&
get_use_mpip()
{
static bool _v = tim::get_env("OMNITRACE_USE_MPIP", true, false);
return _v;
static auto _v = get_config()->find("OMNITRACE_USE_MPIP");
return static_cast<tim::tsettings<bool>&>(*_v->second).get();
}

bool&
Expand Down